* RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl
@ 2006-10-10 6:49 Noguchi, Masato
2006-10-10 8:27 ` [PATCH] spufs: fix support for read/write on cntl Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Noguchi, Masato @ 2006-10-10 6:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linuxppc-dev, Paul Mackerras, Arnd Bergmann, linux-kernel,
cbe-oss-dev
Oops,
I'm so sorry. I mistake to send wrong patch.
Correct version is below:
Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
---
Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
---
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
static struct file_operations spufs_cntl_fops =3D {
.open =3D spufs_cntl_open,
+ .release =3D simple_attr_close,
.read =3D simple_attr_read,
.write =3D simple_attr_write,
.mmap =3D spufs_cntl_mmap,
> -----Original Message-----
> From: Noguchi, Masato
> Sent: Tuesday, October 10, 2006 3:00 PM
> To: 'Arnd Bergmann'
> Cc: Paul Mackerras; Arnd Bergmann; linuxppc-dev@ozlabs.org;
> cbe-oss-dev@ozlabs.org; linux-kernel@vger.kernel.org
> Subject: RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for
read/write
> oncntl
>=20
> After applying these patches, it seems the kernel leaks memory.
> No doubt you forget to call simple_attr_close on "[PATCH 09/14]
> spufs: add support for read/write oncntl".
>=20
> Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
>=20
> ---
>=20
> Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> ---
>
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
> +++
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
> @@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
>=20
> static struct file_operations spufs_cntl_fops =3D {
> .open =3D spufs_cntl_open,
> + .close =3D simple_attr_close,
> .read =3D simple_attr_read,
> .write =3D simple_attr_write,
> .mmap =3D spufs_cntl_mmap,
>=20
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] spufs: fix support for read/write on cntl
2006-10-10 6:49 [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl Noguchi, Masato
@ 2006-10-10 8:27 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2006-10-10 8:27 UTC (permalink / raw)
To: Noguchi, Masato; +Cc: linuxppc-dev, Paul Mackerras, cbe-oss-dev, linux-kernel
From: "Noguchi, Masato" <Masato.Noguchi@jp.sony.com>
This fixes a memory leak introduced by "spufs: add support
for read/write oncntl", which was missing a call to simple_attr_close.
Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
---
On Tuesday 10 October 2006 08:49, Noguchi, Masato wrote:
> Oops,
> I'm so sorry. I mistake to send wrong patch.
Ok, no worries. Paul, please use this patch instead.
Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
--- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
static struct file_operations spufs_cntl_fops = {
.open = spufs_cntl_open,
+ .release = simple_attr_close,
.read = simple_attr_read,
.write = simple_attr_write,
.mmap = spufs_cntl_mmap,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-10 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-10 6:49 [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl Noguchi, Masato
2006-10-10 8:27 ` [PATCH] spufs: fix support for read/write on cntl Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).