From: "Mark A. Greer" <mgreer@mvista.com>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC] bootwrapper: prevent fdt from being overwritten by kernel
Date: Thu, 26 Oct 2006 15:56:53 -0700 [thread overview]
Message-ID: <20061026225653.GA20233@mag.az.mvista.com> (raw)
In-Reply-To: <20061026225045.GA19839@mag.az.mvista.com>
On Thu, Oct 26, 2006 at 03:50:45PM -0700, Mark A. Greer wrote:
> diff --git a/arch/powerpc/boot/main.c b/arch/powerpc/boot/main.c
> index 234bb5b..4927c17 100644
> --- a/arch/powerpc/boot/main.c
> +++ b/arch/powerpc/boot/main.c
> @@ -169,7 +169,7 @@ static int is_elf32(void *hdr)
> return 1;
> }
>
> -static void prep_kernel(unsigned long *a1, unsigned long *a2)
> +static void get_elfheader(void)
> {
> int len;
>
> @@ -186,11 +186,13 @@ static void prep_kernel(unsigned long *a
> sizeof(elfheader));
>
> if (!is_elf64(elfheader) && !is_elf32(elfheader)) {
> - printf("Error: not a valid PPC32 or PPC64 ELF file!\n\r");
> exit();
> }
> - if (platform_ops.image_hdr)
> - platform_ops.image_hdr(elfheader);
> +}
> +
> +static void prep_kernel(unsigned long *a1, unsigned long *a2)
> +{
> + int len;
Oops, the "if (!is_elf64(elfheader) && !is_elf32(elfheader)) {"
check should stay in prep_kernel.
Mark
next prev parent reply other threads:[~2006-10-26 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 22:50 [RFC] bootwrapper: prevent fdt from being overwritten by kernel Mark A. Greer
2006-10-26 22:56 ` Mark A. Greer [this message]
2006-10-30 4:16 ` Paul Mackerras
2006-10-31 23:02 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061026225653.GA20233@mag.az.mvista.com \
--to=mgreer@mvista.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox