From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Kalle Pokki <kalle.pokki@iki.fi>
Cc: Paul Mackerras <paulus@samba.org>, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH/RFC] FS_ENET: Removed MII bitbang check for TA
Date: Wed, 1 Nov 2006 14:37:04 +0300 [thread overview]
Message-ID: <20061101143704.3c8c47cb@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0611011317280.848@host32.eke.fi>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Wed, 1 Nov 2006 13:22:17 +0200 (EET)
Kalle Pokki wrote:
> The PHY abstraction layer expects to receive 0xffff when
> reading PHY registers if there is no PHY at that address. The
> all-ones condition is guaranteed by the pull-up in the MDIO line, so
> there is no need to check for the TA bits.
>
> With this, the PHY layer is able to probe the MDIO bus as it expects.
> This also removes one board dependency from the fs_enet driver, as
> there is no need to set the phy_mask bits anymore.
>
> Signed-off-by: Kalle Pokki <kalle.pokki@iki.fi>
At the first sight this it OK.
I'll give it a try, prolly add some bits and forward along with the other
fs_enet stuff residing in todo.
Thanks,
-Vitaly
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-11-01 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 11:22 [PATCH/RFC] FS_ENET: Removed MII bitbang check for TA Kalle Pokki
2006-11-01 11:37 ` Vitaly Bordug [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101143704.3c8c47cb@localhost.localdomain \
--to=vbordug@ru.mvista.com \
--cc=kalle.pokki@iki.fi \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).