* [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix
@ 2006-11-03 16:47 Thomas Klein
2006-11-06 7:55 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Klein @ 2006-11-03 16:47 UTC (permalink / raw)
To: Jeff Garzik
Cc: Thomas Klein, Jan-Bernd Themann, netdev, linux-kernel,
Christoph Raisch, linux-ppc, Marcus Eder
Fix: Must check for nullpointer before dereferencing it - not afterwards.
Signed-off-by: Thomas Klein <tklein@de.ibm.com>
---
diff -Nurp git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c git.netdev-2.6/drivers/net/ehea/ehea_qmr.c
--- git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c 2006-11-03 14:19:51.000000000 +0100
+++ git.netdev-2.6/drivers/net/ehea/ehea_qmr.c 2006-11-03 14:27:53.000000000 +0100
@@ -209,11 +209,11 @@ int ehea_destroy_cq(struct ehea_cq *cq)
{
u64 adapter_handle, hret;
- adapter_handle = cq->adapter->handle;
-
if (!cq)
return 0;
+ adapter_handle = cq->adapter->handle;
+
/* deregister all previous registered pages */
hret = ehea_h_free_resource(adapter_handle, cq->fw_handle);
if (hret != H_SUCCESS) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix
2006-11-03 16:47 [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix Thomas Klein
@ 2006-11-06 7:55 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-11-06 7:55 UTC (permalink / raw)
To: Thomas Klein
Cc: Thomas Klein, Jan-Bernd Themann, netdev, linux-kernel,
Christoph Raisch, linux-ppc, Marcus Eder
applied 1-3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-06 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-03 16:47 [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix Thomas Klein
2006-11-06 7:55 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).