From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: <linuxppc-dev@ozlabs.org>
Subject: [PATCH 10/31] powerpc: Improve MPIC driver auto-configuration from DT
Date: Tue, 07 Nov 2006 18:22:41 +1100 [thread overview]
Message-ID: <20061107072358.7FD6B6815D@ozlabs.org> (raw)
In-Reply-To: <1162884150.435786.961370643810.qpush@grosgo>
This patch applies on top of the MPIC DCR support. It makes the MPIC
driver capable of a lot more auto-configuration based on the device-tree,
for example, it can retreive it's own physical address if not passed as
an argument, find out if it's DCR or MMIO mapped, and set the BIG_ENDIAN
flag automatically in the presence of a "big-endian" property in the
device-tree node.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/sysdev/mpic.c | 50 +++++++++++++++++++++++++++++++++------------
include/asm-powerpc/mpic.h | 4 +--
2 files changed, 39 insertions(+), 15 deletions(-)
Index: linux-cell/arch/powerpc/sysdev/mpic.c
===================================================================
--- linux-cell.orig/arch/powerpc/sysdev/mpic.c 2006-11-06 14:34:17.000000000 +1100
+++ linux-cell/arch/powerpc/sysdev/mpic.c 2006-11-06 14:36:45.000000000 +1100
@@ -894,7 +894,7 @@ static struct irq_host_ops mpic_host_ops
*/
struct mpic * __init mpic_alloc(struct device_node *node,
- unsigned long phys_addr,
+ phys_addr_t phys_addr,
unsigned int flags,
unsigned int isu_size,
unsigned int irq_count,
@@ -904,6 +904,7 @@ struct mpic * __init mpic_alloc(struct d
u32 reg;
const char *vers;
int i;
+ u64 paddr = phys_addr;
mpic = alloc_bootmem(sizeof(struct mpic));
if (mpic == NULL)
@@ -943,6 +944,11 @@ struct mpic * __init mpic_alloc(struct d
mpic->irq_count = irq_count;
mpic->num_sources = 0; /* so far */
+ /* Check for "big-endian" in device-tree */
+ if (node && get_property(node, "big-endian", NULL) != NULL)
+ mpic->flags |= MPIC_BIG_ENDIAN;
+
+
#ifdef CONFIG_MPIC_WEIRD
mpic->hw_set = mpic_infos[MPIC_GET_REGSET(flags)];
#endif
@@ -951,11 +957,17 @@ struct mpic * __init mpic_alloc(struct d
mpic->reg_type = (flags & MPIC_BIG_ENDIAN) ?
mpic_access_mmio_be : mpic_access_mmio_le;
+ /* If no physical address is passed in, a device-node is mandatory */
+ BUG_ON(paddr == 0 && node == NULL);
+
+ /* If no physical address passed in, check if it's dcr based */
+ if (paddr == 0 && get_property(node, "dcr-reg", NULL) != NULL)
+ mpic->flags |= MPIC_USES_DCR;
+
#ifdef CONFIG_PPC_DCR
if (mpic->flags & MPIC_USES_DCR) {
const u32 *dbasep;
- BUG_ON(mpic->of_node == NULL);
- dbasep = get_property(mpic->of_node, "dcr-reg", NULL);
+ dbasep = get_property(node, "dcr-reg", NULL);
BUG_ON(dbasep == NULL);
mpic->dcr_base = *dbasep;
mpic->reg_type = mpic_access_dcr;
@@ -964,9 +976,20 @@ struct mpic * __init mpic_alloc(struct d
BUG_ON (mpic->flags & MPIC_USES_DCR);
#endif /* CONFIG_PPC_DCR */
+ /* If the MPIC is not DCR based, and no physical address was passed
+ * in, try to obtain one
+ */
+ if (paddr == 0 && !(mpic->flags & MPIC_USES_DCR)) {
+ const u32 *reg;
+ reg = get_property(node, "reg", NULL);
+ BUG_ON(reg == NULL);
+ paddr = of_translate_address(node, reg);
+ BUG_ON(paddr == OF_BAD_ADDR);
+ }
+
/* Map the global registers */
- mpic_map(mpic, phys_addr, &mpic->gregs, MPIC_INFO(GREG_BASE), 0x1000);
- mpic_map(mpic, phys_addr, &mpic->tmregs, MPIC_INFO(TIMER_BASE), 0x1000);
+ mpic_map(mpic, paddr, &mpic->gregs, MPIC_INFO(GREG_BASE), 0x1000);
+ mpic_map(mpic, paddr, &mpic->tmregs, MPIC_INFO(TIMER_BASE), 0x1000);
/* Reset */
if (flags & MPIC_WANTS_RESET) {
@@ -991,7 +1014,7 @@ struct mpic * __init mpic_alloc(struct d
/* Map the per-CPU registers */
for (i = 0; i < mpic->num_cpus; i++) {
- mpic_map(mpic, phys_addr, &mpic->cpuregs[i],
+ mpic_map(mpic, paddr, &mpic->cpuregs[i],
MPIC_INFO(CPU_BASE) + i * MPIC_INFO(CPU_STRIDE),
0x1000);
}
@@ -999,7 +1022,7 @@ struct mpic * __init mpic_alloc(struct d
/* Initialize main ISU if none provided */
if (mpic->isu_size == 0) {
mpic->isu_size = mpic->num_sources;
- mpic_map(mpic, phys_addr, &mpic->isus[0],
+ mpic_map(mpic, paddr, &mpic->isus[0],
MPIC_INFO(IRQ_BASE), MPIC_INFO(IRQ_STRIDE) * mpic->isu_size);
}
mpic->isu_shift = 1 + __ilog2(mpic->isu_size - 1);
@@ -1020,10 +1043,11 @@ struct mpic * __init mpic_alloc(struct d
vers = "<unknown>";
break;
}
- printk(KERN_INFO "mpic: Setting up MPIC \"%s\" version %s at %lx, max %d CPUs\n",
- name, vers, phys_addr, mpic->num_cpus);
- printk(KERN_INFO "mpic: ISU size: %d, shift: %d, mask: %x\n", mpic->isu_size,
- mpic->isu_shift, mpic->isu_mask);
+ printk(KERN_INFO "mpic: Setting up MPIC \"%s\" version %s at %llx,"
+ " max %d CPUs\n",
+ name, vers, (unsigned long long)paddr, mpic->num_cpus);
+ printk(KERN_INFO "mpic: ISU size: %d, shift: %d, mask: %x\n",
+ mpic->isu_size, mpic->isu_shift, mpic->isu_mask);
mpic->next = mpics;
mpics = mpic;
@@ -1037,13 +1061,13 @@ struct mpic * __init mpic_alloc(struct d
}
void __init mpic_assign_isu(struct mpic *mpic, unsigned int isu_num,
- unsigned long phys_addr)
+ phys_addr_t paddr)
{
unsigned int isu_first = isu_num * mpic->isu_size;
BUG_ON(isu_num >= MPIC_MAX_ISU);
- mpic_map(mpic, phys_addr, &mpic->isus[isu_num], 0,
+ mpic_map(mpic, paddr, &mpic->isus[isu_num], 0,
MPIC_INFO(IRQ_STRIDE) * mpic->isu_size);
if ((isu_first + mpic->isu_size) > mpic->num_sources)
mpic->num_sources = isu_first + mpic->isu_size;
Index: linux-cell/include/asm-powerpc/mpic.h
===================================================================
--- linux-cell.orig/include/asm-powerpc/mpic.h 2006-11-06 14:34:17.000000000 +1100
+++ linux-cell/include/asm-powerpc/mpic.h 2006-11-06 14:34:38.000000000 +1100
@@ -364,7 +364,7 @@ struct mpic
* that is senses[0] correspond to linux irq "irq_offset".
*/
extern struct mpic *mpic_alloc(struct device_node *node,
- unsigned long phys_addr,
+ phys_addr_t phys_addr,
unsigned int flags,
unsigned int isu_size,
unsigned int irq_count,
@@ -377,7 +377,7 @@ extern struct mpic *mpic_alloc(struct de
* @phys_addr: physical address of the ISU
*/
extern void mpic_assign_isu(struct mpic *mpic, unsigned int isu_num,
- unsigned long phys_addr);
+ phys_addr_t phys_addr);
/* Set default sense codes
*
next prev parent reply other threads:[~2006-11-07 7:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 7:22 [PATCH 0/31] My current serie of patches for 2.6.20 for review Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 1/31] ibmveth: Remove ibmveth "liobn" field Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 3/31] Driver core: add notification of bus events Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 2/31] Call platform_notify_remove later Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 4/31] arch provides generic iomap missing accessors Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 6/31] powerpc: Remove ppc_md.pci_map_irq & ppc_swizzle for ARCH=powerpc Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 5/31] powerpc: Make pci_read_irq_line the default Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 7/31] powerpc: Generic DCR infrastructure Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 8/31] powerpc: Make EMAC use generic DCR access methods Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 9/31] powerpc: Support for DCR based MPIC Benjamin Herrenschmidt
2006-11-07 7:22 ` Benjamin Herrenschmidt [this message]
2006-11-07 7:22 ` [PATCH 11/31] powerpc: Native cell support for MPIC in southbridge Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 12/31] powerpc: Souped-up of_platform_device support Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 13/31] powerpc: Hook of_platform_bus_probe with cell Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 14/31] powerpc: Refactor 64 bits DMA operations Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 15/31] powerpc: PCI use new bus device notifier Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 16/31] powerpc: Add DMA ops support for of_plaform_device to Cell Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 17/31] powerpc: Resolve the parent address of a PCI bus range Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 18/31] powerpc: Resolve the BUID fir RTAS PCI config space accesses Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 19/31] powerpc: Add "parent" struct device for PCI host bridges Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 21/31] powerpc: Cell fixup DMA offset for new southbridge Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 20/31] powerpc: Generic OF platform driver for PCI host bridges Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 22/31] powerpc: Allow hooking of PCI MMIO & PIO accessors on 64 bits Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 23/31] powerpc: Cell "Spider" MMIO workarounds Benjamin Herrenschmidt
2006-11-07 11:55 ` Christoph Hellwig
2006-11-07 20:29 ` Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 24/31] powerpc: spider uses low level BE MMIO accessors Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 25/31] powerpc: Add an optional offset to direct DMA on 64 bits Benjamin Herrenschmidt
2006-11-07 7:22 ` [PATCH 26/31] powerpc: Make direct DMA use node local allocations Benjamin Herrenschmidt
2006-11-07 7:23 ` [PATCH 27/31] powerpc: Make cell use direct DMA ops Benjamin Herrenschmidt
2006-11-07 7:23 ` [PATCH 28/31] powerpc: Cell iommu support Benjamin Herrenschmidt
2006-11-07 7:23 ` [PATCH 29/31] powerpc: remove ioremap64 and fixup_bigphys_addr Benjamin Herrenschmidt
2006-11-07 7:23 ` [PATCH 30/31] powerpc: Merge 32 and 64 bits asm-powerpc/io.h Benjamin Herrenschmidt
2006-11-07 7:23 ` [PATCH 31/31] powerpc: EMAC of_platform_device support for Cell using Axon Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107072358.7FD6B6815D@ozlabs.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).