linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: <linuxppc-dev@ozlabs.org>
Subject: [PATCH 15/31] powerpc: PCI use new bus device notifier
Date: Tue, 07 Nov 2006 18:22:47 +1100	[thread overview]
Message-ID: <20061107072405.0995468265@ozlabs.org> (raw)
In-Reply-To: <1162884150.435786.961370643810.qpush@grosgo>

This makes the PCI code on 64 bits use the new bus device notifier
introduced by the 3rd patch of that queue instead of the old style
platform notify callbacks, for handling destruction of the device
extension for PCI devices.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
 
 arch/powerpc/kernel/pci_64.c   |   47 ++++++++++++++++++++++-------------------
 arch/powerpc/kernel/setup_64.c |    4 ---
 2 files changed, 26 insertions(+), 25 deletions(-)

Index: linux-cell/arch/powerpc/kernel/setup_64.c
===================================================================
--- linux-cell.orig/arch/powerpc/kernel/setup_64.c	2006-10-26 16:43:32.000000000 +1000
+++ linux-cell/arch/powerpc/kernel/setup_64.c	2006-10-26 16:44:09.000000000 +1000
@@ -531,10 +531,6 @@ void __init setup_arch(char **cmdline_p)
 	conswitchp = &dummy_con;
 #endif
 
-#ifdef CONFIG_PCI
-	platform_notify = pci_platform_notify;
-	platform_notify_remove = pci_platform_notify_remove;
-#endif
 	ppc_md.setup_arch();
 
 	paging_init();
Index: linux-cell/arch/powerpc/kernel/pci_64.c
===================================================================
--- linux-cell.orig/arch/powerpc/kernel/pci_64.c	2006-10-26 16:43:32.000000000 +1000
+++ linux-cell/arch/powerpc/kernel/pci_64.c	2006-10-26 16:44:09.000000000 +1000
@@ -22,6 +22,7 @@
 #include <linux/list.h>
 #include <linux/syscalls.h>
 #include <linux/irq.h>
+#include <linux/notifier.h>
 
 #include <asm/processor.h>
 #include <asm/io.h>
@@ -554,6 +555,29 @@ void __devinit scan_phb(struct pci_contr
 		hose->last_busno = bus->subordinate = pci_scan_child_bus(bus);
 }
 
+static int ppc_pci_dev_notify(struct notifier_block *nb, unsigned long action,
+			      void *data)
+{
+	struct device *dev = data;
+	struct device_ext *dext;
+
+	if (action == BUS_NOTIFY_DEL_DEVICE) {
+		dext = device_get_ext(dev);
+
+		DBG("%s:%s platform notify remove !\n",
+		    dev_driver_string(dev), dev->bus_id);
+
+		device_set_ext(dev, NULL);
+		kfree(dext);
+	}
+
+	return 0;
+}
+
+static struct notifier_block ppc_pci_dev_notifier = {
+	.notifier_call = ppc_pci_dev_notify
+};
+
 static int __init pcibios_init(void)
 {
 	struct pci_controller *hose, *tmp;
@@ -566,6 +590,8 @@ static int __init pcibios_init(void)
 	if (firmware_has_feature(FW_FEATURE_ISERIES))
 		iSeries_pcibios_init();
 
+	register_bus_notifier(&pci_bus_type, &ppc_pci_dev_notifier);
+
 	printk(KERN_DEBUG "PCI: Probing PCI hardware\n");
 
 	/* Scan all of the recorded PCI controllers.  */
@@ -1458,24 +1484,3 @@ int pcibus_to_node(struct pci_bus *bus)
 EXPORT_SYMBOL(pcibus_to_node);
 #endif
 
-int pci_platform_notify(struct device * dev)
-{
-	return 0;
-}
-
-int pci_platform_notify_remove(struct device * dev)
-{
-	struct device_ext *dext = device_get_ext(dev);
-
-	DBG("%s:%s platform notify remove !\n",
-	    dev_driver_string(dev), dev->bus_id);
-
-	if (dev->bus != &pci_bus_type)
-		return 0;
-
-	device_set_ext(dev, NULL);
-	mb();
-	kfree(dext);
-
-	return 0;
-}

  parent reply	other threads:[~2006-11-07  7:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-07  7:22 [PATCH 0/31] My current serie of patches for 2.6.20 for review Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 1/31] ibmveth: Remove ibmveth "liobn" field Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 2/31] Call platform_notify_remove later Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 3/31] Driver core: add notification of bus events Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 4/31] arch provides generic iomap missing accessors Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 5/31] powerpc: Make pci_read_irq_line the default Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 6/31] powerpc: Remove ppc_md.pci_map_irq & ppc_swizzle for ARCH=powerpc Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 7/31] powerpc: Generic DCR infrastructure Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 8/31] powerpc: Make EMAC use generic DCR access methods Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 9/31] powerpc: Support for DCR based MPIC Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 10/31] powerpc: Improve MPIC driver auto-configuration from DT Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 11/31] powerpc: Native cell support for MPIC in southbridge Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 12/31] powerpc: Souped-up of_platform_device support Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 13/31] powerpc: Hook of_platform_bus_probe with cell Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 14/31] powerpc: Refactor 64 bits DMA operations Benjamin Herrenschmidt
2006-11-07  7:22 ` Benjamin Herrenschmidt [this message]
2006-11-07  7:22 ` [PATCH 16/31] powerpc: Add DMA ops support for of_plaform_device to Cell Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 17/31] powerpc: Resolve the parent address of a PCI bus range Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 18/31] powerpc: Resolve the BUID fir RTAS PCI config space accesses Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 19/31] powerpc: Add "parent" struct device for PCI host bridges Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 20/31] powerpc: Generic OF platform driver " Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 21/31] powerpc: Cell fixup DMA offset for new southbridge Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 22/31] powerpc: Allow hooking of PCI MMIO & PIO accessors on 64 bits Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 23/31] powerpc: Cell "Spider" MMIO workarounds Benjamin Herrenschmidt
2006-11-07 11:55   ` Christoph Hellwig
2006-11-07 20:29     ` Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 25/31] powerpc: Add an optional offset to direct DMA on 64 bits Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 24/31] powerpc: spider uses low level BE MMIO accessors Benjamin Herrenschmidt
2006-11-07  7:22 ` [PATCH 26/31] powerpc: Make direct DMA use node local allocations Benjamin Herrenschmidt
2006-11-07  7:23 ` [PATCH 27/31] powerpc: Make cell use direct DMA ops Benjamin Herrenschmidt
2006-11-07  7:23 ` [PATCH 29/31] powerpc: remove ioremap64 and fixup_bigphys_addr Benjamin Herrenschmidt
2006-11-07  7:23 ` [PATCH 28/31] powerpc: Cell iommu support Benjamin Herrenschmidt
2006-11-07  7:23 ` [PATCH 30/31] powerpc: Merge 32 and 64 bits asm-powerpc/io.h Benjamin Herrenschmidt
2006-11-07  7:23 ` [PATCH 31/31] powerpc: EMAC of_platform_device support for Cell using Axon Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061107072405.0995468265@ozlabs.org \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).