From: Judith Lebzelter <judith@osdl.org>
To: sfr@canb.auug.org.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: build problems with powerpc allmodconfig
Date: Tue, 7 Nov 2006 10:09:37 -0800 [thread overview]
Message-ID: <20061107180937.GB1339@shell0.pdx.osdl.net> (raw)
>> - vioscsi linkage fails because iseries_vscsi.c and rpa_vscsi.c.
>> This needs some trivial indirection via function vectors, but
>> how can we find out which one to use from the driver? Both
>> seem to look the same in the device tree
>
> The maintainer suggested that we just don't build vioscsi for iseries
> if we are building the rpa version as it is not often used (in particular,
> it is not used for installations). We could, however distinguish them
> by changing the "compat" field in the iSeries device tree if we wished.
>
How about just adding an 'ifndef' in the Makefile, as in the patch below?
This compiles ibmvscsic.o fine.
Judith Lebzelter
---
Index: linux/drivers/scsi/ibmvscsi/Makefile
===================================================================
--- linux.orig/drivers/scsi/ibmvscsi/Makefile 2006-11-06 16:52:09.000000000 -0800
+++ linux/drivers/scsi/ibmvscsi/Makefile 2006-11-07 09:35:34.019969437 -0800
@@ -1,7 +1,9 @@
obj-$(CONFIG_SCSI_IBMVSCSI) += ibmvscsic.o
ibmvscsic-y += ibmvscsi.o
+ifndef CONFIG_PPC_PSERIES
ibmvscsic-$(CONFIG_PPC_ISERIES) += iseries_vscsi.o
+endif
ibmvscsic-$(CONFIG_PPC_PSERIES) += rpa_vscsi.o
obj-$(CONFIG_SCSI_IBMVSCSIS) += ibmvstgt.o
next reply other threads:[~2006-11-07 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 18:09 Judith Lebzelter [this message]
2006-11-08 0:58 ` build problems with powerpc allmodconfig Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2006-10-31 14:22 Christoph Hellwig
2006-10-31 15:22 ` Stephen Rothwell
2006-10-31 15:24 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107180937.GB1339@shell0.pdx.osdl.net \
--to=judith@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox