linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org, michael@ellerman.id.au
Cc: Paul Mackerras <paulus@samba.org>, Michael Neuling <mikey@neuling.org>
Subject: Re: [PATCH] powerpc: force 4k update_flash block and list sizes
Date: Wed, 8 Nov 2006 10:28:31 +0100	[thread overview]
Message-ID: <200611081028.32038.arnd@arndb.de> (raw)
In-Reply-To: <1162960860.20271.13.camel@localhost.localdomain>

On Wednesday 08 November 2006 05:41, Michael Ellerman wrote:
> Just being picky .. but why did you decide to use the slab cache? Does
> it make the code neater? I would have thought you could guarantee 4k
> alignment some other way, and it seems slightly odd to use the slab
> cache for something you only do once ..

There are not so many allocators available. kmalloc does not guarantee
alignment beyond a few bytes and the buddy allocator and vmalloc don't
give you allocations smaller than PAGE_SIZE.

The ehca people had the same problem, and I could imagine there are
others with similar issues. How about adding a special slab allocator
architecture-wide that gives out aligned 4k chunks independent of
page size?

	Arnd <>z

  reply	other threads:[~2006-11-08  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-07 23:53 [PATCH] powerpc: force 4k update_flash block and list sizes John Rose
2006-11-08  2:06 ` Michael Neuling
2006-11-08  4:30   ` John Rose
2006-11-08  4:39     ` Michael Neuling
2006-11-08 16:07       ` John Rose
2006-11-08  4:41     ` Michael Ellerman
2006-11-08  9:28       ` Arnd Bergmann [this message]
2006-11-08 22:40         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611081028.32038.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).