From: linas@austin.ibm.com (Linas Vepstas)
To: paulus@samba.org
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH]: PowerPC: make sure the rtas stop-self token is defined.
Date: Fri, 10 Nov 2006 12:22:53 -0600 [thread overview]
Message-ID: <20061110182253.GV30625@austin.ibm.com> (raw)
Paul,
I presume this looks reasonable, please apply.
--linas
There are a variety of code paths that lead to rtas_stop_self()
being called, primarily through cpu_die(). However, rtas_stop_self()
has a BUG_ON(rtas_args->token == RTAS_UNKNOWN_SERVICE); in it, and
this rtas token is only set up if CONFIG_HOTPLUG_CPU is defined.
Rather than wrapping all of the callers of rtas_stop_self()
with CONFIG_HOTPLUG_CPU, it seems wiser to just unwrap the token
definition.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
----
arch/powerpc/kernel/rtas.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-2.6.19-rc4-git3/arch/powerpc/kernel/rtas.c
===================================================================
--- linux-2.6.19-rc4-git3.orig/arch/powerpc/kernel/rtas.c 2006-11-10 12:13:17.000000000 -0600
+++ linux-2.6.19-rc4-git3/arch/powerpc/kernel/rtas.c 2006-11-10 12:13:40.000000000 -0600
@@ -879,9 +879,7 @@ void __init rtas_initialize(void)
#endif
rtas_rmo_buf = lmb_alloc_base(RTAS_RMOBUF_MAX, PAGE_SIZE, rtas_region);
-#ifdef CONFIG_HOTPLUG_CPU
rtas_stop_self_args.token = rtas_token("stop-self");
-#endif
#ifdef CONFIG_RTAS_ERROR_LOGGING
rtas_last_error_token = rtas_token("rtas-last-error");
#endif
next reply other threads:[~2006-11-10 18:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 18:22 Linas Vepstas [this message]
2006-11-10 20:01 ` [PATCH]: PowerPC: make sure the rtas stop-self token is defined Nathan Lynch
2006-11-11 1:01 ` Linas Vepstas
2006-11-13 0:32 ` Michael Ellerman
2006-11-13 6:21 ` jschopp
2006-11-13 18:05 ` Linas Vepstas
2006-11-14 1:17 ` Michael Ellerman
2006-11-15 18:08 ` Linas Vepstas
2006-11-10 23:55 ` Paul Mackerras
2006-11-11 0:52 ` Linas Vepstas
2006-11-13 18:57 ` Nathan Lynch
2006-11-13 19:39 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110182253.GV30625@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).