From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 8/16] powerpc: add ps3 platform hvcalls
Date: Sat, 11 Nov 2006 03:13:40 +0100 [thread overview]
Message-ID: <200611110313.40940.arnd@arndb.de> (raw)
In-Reply-To: <4554DAD7.2090709@am.sony.com>
On Friday 10 November 2006 21:02, Geoff Levand wrote:
> Adds the ps3pf hvcalls.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
This one reminds of the inline hcall abstraction layer I did
some time ago. The implementation in your patch is a lot
less elegant than both the pseries in its current incarnation
and the one that I did (IMHO). Any opinions on how we should
proceed here?
I can dig out my patch again in the version I did for the
ps3 hypervisor, if there is demand, or I could help moving
over so code that is more like the pseries one. Unfortunately
the calling conventions are very different from pseries
(the hcall number is passed in r11, not in one of the argument
registers), so that would not be as nice as Anton's implementation.
Arnd <><
next prev parent reply other threads:[~2006-11-11 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 20:02 [PATCH 8/16] powerpc: add ps3 platform hvcalls Geoff Levand
2006-11-11 2:13 ` Arnd Bergmann [this message]
2006-11-11 11:22 ` Christoph Hellwig
2006-11-12 0:46 ` Benjamin Herrenschmidt
2006-11-13 3:52 ` Geoff Levand
2006-11-13 11:30 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611110313.40940.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).