From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sunset.davemloft.net (dsl027-180-168.sfo1.dsl.speakeasy.net [216.27.180.168]) by ozlabs.org (Postfix) with ESMTP id 01C2567D4D for ; Tue, 14 Nov 2006 16:07:41 +1100 (EST) Date: Mon, 13 Nov 2006 21:07:50 -0800 (PST) Message-Id: <20061113.210750.66175955.davem@davemloft.net> To: benh@kernel.crashing.org Subject: Re: [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X From: David Miller In-Reply-To: <1163469594.5940.42.camel@localhost.localdomain> References: <1163405790.4982.289.camel@localhost.localdomain> <20061113.163138.98554015.davem@davemloft.net> <1163469594.5940.42.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: idr@us.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org, airlied@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Benjamin Herrenschmidt Date: Tue, 14 Nov 2006 12:59:54 +1100 > If I "fix" the kernel to do the right thing, that is pass BAR values in > devices and expect BAR values in mmap, then I will break existing X > setups on machines where PCI is not mapped 1:1 (that is mostly CHRP > machines). > > The problem I'm fixing in this patch is that while we were providing the > hacked up value in "devices", we were expecting the BAR value in mmap, > and there are apps expecting us to be consistent between the two, thus > the breakage. Ok, I don't see much alternatives for you then. I have no real objections to your patch.