From: Christoph Hellwig <hch@lst.de>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 11/16] powerpc: add ps3 platform repository support
Date: Wed, 15 Nov 2006 19:06:13 +0100 [thread overview]
Message-ID: <20061115180613.GC18856@lst.de> (raw)
In-Reply-To: <4554DAFC.1070804@am.sony.com>
On Fri, Nov 10, 2006 at 12:03:08PM -0800, Geoff Levand wrote:
> + * make_first_field - Make the first field of a repository node name.
> + * @text: Text portion of the field.
> + * @index: Numeric index portion of the field. Use zero for 'don't care'.
> + *
> + * This routine sets the vendor id to zero (non-vendor specific).
> + * Returns field value.
> + */
> +
> +static u64 make_first_field(const char *text, u64 index)
> +{
> + u64 n;
> +
> + strncpy((char *)&n, text, 8);
> + return ps3pf_vendor_id_none + (n >> 32) + index;
> +}
a strncpy into a const pointer doesn't make any sense.
next prev parent reply other threads:[~2006-11-15 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 20:03 [PATCH 11/16] powerpc: add ps3 platform repository support Geoff Levand
2006-11-15 18:06 ` Christoph Hellwig [this message]
2006-11-16 0:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061115180613.GC18856@lst.de \
--to=hch@lst.de \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).