linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: linas@austin.ibm.com (Linas Vepstas)
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, Nathan Lynch <ntl@pobox.com>, paulus@samba.org
Subject: Re: [PATCH]: PowerPC: make sure the rtas stop-self token is defined.
Date: Wed, 15 Nov 2006 12:08:14 -0600	[thread overview]
Message-ID: <20061115180814.GG8395@austin.ibm.com> (raw)
In-Reply-To: <1163467065.8048.37.camel@localhost.localdomain>

On Tue, Nov 14, 2006 at 12:17:44PM +1100, Michael Ellerman wrote:
> On Mon, 2006-11-13 at 12:05 -0600, Linas Vepstas wrote:
> > 
> > Well, the problem is that this would just pass the BUG() to 
> > the next level, in pSeries_mach_cpu_die():
> > 
> > static void pSeries_mach_cpu_die(void)
> > {
> >    local_irq_disable();
> >    idle_task_exit();
> >    xics_teardown_cpu(0);
> >    rtas_stop_self();
> >    /* Should never get here... */
> >    BUG();
> >    for(;;);
> > }
> > 
> > so does that mean that CONFIG_HOTPLUG_CPU should also be used to 
> > stop the complation of pSeries_mach_cpu_die() ? 
> 
> Yes. And its connection to ppc_md.cpu_die.

OK, will send patch for this shortly. I reviewed the other cases,
and see now that this would e the consistent thing to do.

--linas

  reply	other threads:[~2006-11-15 18:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-10 18:22 [PATCH]: PowerPC: make sure the rtas stop-self token is defined Linas Vepstas
2006-11-10 20:01 ` Nathan Lynch
2006-11-11  1:01   ` Linas Vepstas
2006-11-13  0:32     ` Michael Ellerman
2006-11-13  6:21       ` jschopp
2006-11-13 18:05         ` Linas Vepstas
2006-11-14  1:17           ` Michael Ellerman
2006-11-15 18:08             ` Linas Vepstas [this message]
2006-11-10 23:55 ` Paul Mackerras
2006-11-11  0:52   ` Linas Vepstas
2006-11-13 18:57     ` Nathan Lynch
2006-11-13 19:39       ` Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061115180814.GG8395@austin.ibm.com \
    --to=linas@austin.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=ntl@pobox.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).