From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/16] add hypervisor support for SPU
Date: Thu, 16 Nov 2006 00:33:18 +0100 [thread overview]
Message-ID: <200611160033.18959.arnd@arndb.de> (raw)
In-Reply-To: <20061115182636.GA21633@lst.de>
On Wednesday 15 November 2006 19:26, Christoph Hellwig wrote:
> On Wed, Nov 15, 2006 at 06:28:46PM +0900, Ishizaki Kou wrote:
> > This patch adds hypervisor support for spu.
> >
> > Linux(GuestOS) needs to designate SPE ID number when it uses SPE on Beat,
> > and must read the number from DT.
>
> In addition to the comments from Arnd which I'd like to second, what
> do you need int_mask_lock for? It's initialized but never used.
It's used in patch 14/16 for the hypervisor access. As far as I can
see, it should be possible to use the existing register lock in it's
place though. We should hold that lock before calling any of the
priv1 accessors. In order to verify if this is done right,
you could add BUG_ON(!spin_is_locked(&spu->register_lock));
in the beat version of int_mask_{and,or,get,set}.
Arnd <><
next prev parent reply other threads:[~2006-11-15 23:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 9:28 [PATCH 2/16] add hypervisor support for SPU Ishizaki Kou
2006-11-15 15:47 ` Arnd Bergmann
2006-11-15 18:26 ` Christoph Hellwig
2006-11-15 23:33 ` Arnd Bergmann [this message]
2006-11-17 10:45 ` Ishizaki Kou
2006-11-17 14:01 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2006-11-17 10:33 Ishizaki Kou
2006-11-17 21:28 ` Arnd Bergmann
2006-11-21 13:42 ` Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611160033.18959.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).