From: Alan <alan@lxorguk.ukuu.org.uk>
To: Sylvain Munaut <tnt@246tNt.com>
Cc: Benjamin, Sylvain Munaut <tnt@246tNt.com>,
Linux PPC Embedded <linuxppc-embedded@ozlabs.org>,
Sven Luther <sl@bplan-gmbh.de>,
Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH/RFC] ata: Add support for the MPC52xx ATA controller using libata
Date: Thu, 16 Nov 2006 23:46:01 +0000 [thread overview]
Message-ID: <20061116234601.78325642@localhost.localdomain> (raw)
In-Reply-To: <11637151391017-git-send-email-tnt@246tNt.com>
On Thu, 16 Nov 2006 23:12:19 +0100
Sylvain Munaut <tnt@246tNt.com> wrote:
> * The manual states we should check for the TIP bit before all
> PIO transaction. That's not really supported by libata and requires
> reimplementing almost all the hooks. But after talking to Freescale,
> it turnsout it's not really necessary. So this driver doesn't implement
> that check. I noticed no problem so far ...
>
All PIO transactions meaning each PIO command sequence or each register
read/write ? In the former case is it not enough just to wrap the command
write ?
> * This driver doesn't use the standard function to compute timing
> because the 5200 needs more timing parameters that are not handled
> by the generic call (ta and t4).
I'd rather the generic code was taught to compute any extra times you
need but it seems clean enough.
next prev parent reply other threads:[~2006-11-17 0:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 22:12 [PATCH/RFC] ata: Add support for the MPC52xx ATA controller using libata Sylvain Munaut
2006-11-16 23:46 ` Alan [this message]
2006-11-17 19:12 ` Sylvain Munaut
2006-11-17 18:49 ` Jarno Manninen
2006-11-17 19:09 ` Sylvain Munaut
2006-11-17 22:41 ` Jeff Garzik
2006-11-17 23:21 ` Sylvain Munaut
2006-11-19 19:14 ` Nicolas DET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061116234601.78325642@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=sl@bplan-gmbh.de \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).