From: Christoph Hellwig <hch@lst.de>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/5] [POWERPC] 8xx: generic 8xx code arch/powerpc port
Date: Fri, 17 Nov 2006 09:00:52 +0100 [thread overview]
Message-ID: <20061117080052.GA16985@lst.de> (raw)
In-Reply-To: <20061114012816.17455.12059.stgit@localhost.localdomain>
I've done some grepping, so here are some more useful comments on
the fault.c additions:
> +#ifdef CONFIG_8xx
> +
> +/* The pgtable.h claims some functions generically exist, but I
> + * can't find them......
> + */
This comment is copied from arch/ppc/ but utterly wrong - no one
but 8xx implements any of these functions. I'd say just kill it.
> +pte_t *va_to_pte(unsigned long address)
this is used by arch/ppc/fec.c to set mapping uncachable, which
seems rather odd to me. For now we'll have to keep it I think, but
it might make sense to move the implementation to fec.c.
> +unsigned long va_to_phys(unsigned long address)
this is completely unused. You should probably remove it from arch/ppc
aswell.
> +void
> +print_8xx_pte(struct mm_struct *mm, unsigned long addr)
> +int
> +get_8xx_pte(struct mm_struct *mm, unsigned long addr)
These two are only used by arch/ppc/kernel/softemu8xx.c and should
bew move to that file.
next prev parent reply other threads:[~2006-11-17 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061114012504.17455.13833.stgit@localhost.localdomain>
2006-11-14 1:28 ` [PATCH 1/5] [POWERPC] 8xx: platform-specific mmu updates Vitaly Bordug
2006-11-14 1:28 ` [PATCH 2/5] [POWERPC] 8xx: generic 8xx code arch/powerpc port Vitaly Bordug
2006-11-15 18:23 ` Christoph Hellwig
2006-11-15 23:36 ` Vitaly Bordug
2006-11-16 22:48 ` Benjamin Herrenschmidt
2006-11-17 6:49 ` Christoph Hellwig
2006-11-17 8:00 ` Christoph Hellwig [this message]
2006-11-18 1:24 ` Dan Malek
2006-11-20 10:24 ` Christoph Hellwig
2006-11-21 0:26 ` Dan Malek
2006-11-14 1:28 ` [PATCH 3/5] [POWERPC] 8xx: platform-related changes to the fsl_soc.c Vitaly Bordug
2006-11-14 2:21 ` Benjamin Herrenschmidt
2006-11-14 12:48 ` Vitaly Bordug
2006-11-14 1:28 ` [PATCH 4/5] [POWERPC] 8xx: powerpc port of core CPM, CPM PIC, etc Vitaly Bordug
2006-11-14 2:44 ` Benjamin Herrenschmidt
2006-11-14 1:28 ` [PATCH 5/5] [POWERPC] 8xx: Add mpc885ads support and common mpc8xx Vitaly Bordug
2006-11-14 2:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117080052.GA16985@lst.de \
--to=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).