[PATCH] setup_kcore(): Fix incorrect function name in panic() call.

[PATCH] setup_kcore(): Fix incorrect function name in panic() call.

[Geert Uytterhoeven]

setup_kcore(): Fix incorrect function name in panic() call.

Signed-Off-By: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>

--- linux-ps3-geert.orig/arch/powerpc/mm/init_64.c	2006-11-15 10:05:17.000000000 +0900
+++ linux-ps3-geert/arch/powerpc/mm/init_64.c	2006-11-17 12:36:49.000000000 +0900
@@ -130,7 +130,7 @@ static int __init setup_kcore(void)
 		/* GFP_ATOMIC to avoid might_sleep warnings during boot */
 		kcore_mem = kmalloc(sizeof(struct kcore_list), GFP_ATOMIC);
 		if (!kcore_mem)
-			panic("mem_init: kmalloc failed\n");
+			panic("setup_kcore: kmalloc failed\n");
 
 		kclist_add(kcore_mem, __va(base), size);
 	}

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: [PATCH] setup_kcore(): Fix incorrect function name in panic() call.

[Jeremy Kerr]

Geert,

> -			panic("mem_init: kmalloc failed\n");
> +			panic("setup_kcore: kmalloc failed\n");

How about:
	
	panic("%s: kmalloc_failed\n", __FUNCTION__);

To prevent this happening again?


Jeremy

Re: [PATCH] setup_kcore(): Fix incorrect function name in panic() call.

[Geert Uytterhoeven]

On Fri, 17 Nov 2006, Jeremy Kerr wrote:
> 
> > -			panic("mem_init: kmalloc failed\n");
> > +			panic("setup_kcore: kmalloc failed\n");
> 
> How about:
> 	
> 	panic("%s: kmalloc_failed\n", __FUNCTION__);
> 
> To prevent this happening again?

You're right, thanks for the suggestion!

Gr{oetje,eeting}s,

						Geert

P.S. I was quite convinced panic() didn't do printf() style formatting, but
     apparently that's not (no longer?) true.
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: [PATCH] setup_kcore(): Fix incorrect function name in panic() call.

[Geert Uytterhoeven]

On Fri, 17 Nov 2006, Geert Uytterhoeven wrote:
> On Fri, 17 Nov 2006, Jeremy Kerr wrote:
> > 
> > > -			panic("mem_init: kmalloc failed\n");
> > > +			panic("setup_kcore: kmalloc failed\n");
> > 
> > How about:
> > 	
> > 	panic("%s: kmalloc_failed\n", __FUNCTION__);
> > 
> > To prevent this happening again?
> 
> You're right, thanks for the suggestion!

Updated patch below:
---

Subject: [PATCH] setup_kcore(): Fix incorrect function name in panic() call.

setup_kcore(): Fix incorrect function name in panic() call.

Signed-Off-By: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>

--- linux-ps3-geert.orig/arch/powerpc/mm/init_64.c	2006-11-15 10:05:17.000000000 +0900
+++ linux-ps3-geert/arch/powerpc/mm/init_64.c	2006-11-17 12:36:49.000000000 +0900
@@ -130,7 +130,7 @@ static int __init setup_kcore(void)
 		/* GFP_ATOMIC to avoid might_sleep warnings during boot */
 		kcore_mem = kmalloc(sizeof(struct kcore_list), GFP_ATOMIC);
 		if (!kcore_mem)
-			panic("mem_init: kmalloc failed\n");
+			panic("%s: kmalloc failed\n", __FUNCTION__);
 
 		kclist_add(kcore_mem, __va(base), size);
 	}


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: [PATCH] setup_kcore(): Fix incorrect function name in panic() call.

[Paul Mackerras]

Geert Uytterhoeven writes:

> On Fri, 17 Nov 2006, Geert Uytterhoeven wrote:
> > On Fri, 17 Nov 2006, Jeremy Kerr wrote:
> > > 
> > > > -			panic("mem_init: kmalloc failed\n");
> > > > +			panic("setup_kcore: kmalloc failed\n");
> > > 
> > > How about:
> > > 	
> > > 	panic("%s: kmalloc_failed\n", __FUNCTION__);
> > > 
> > > To prevent this happening again?
> > 
> > You're right, thanks for the suggestion!
> 
> Updated patch below:

Grumble.

Please don't send patches that you want to go upstream with a subject
starting with "Re:" and a whole pile of stuff preceding the patch
description.  Do it like Andrew Morton describes in:

http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Regards,
Paul.