From: linas@austin.ibm.com (Linas Vepstas)
To: Michael Ellerman <michael@ellerman.id.au>
Cc: srinivasa@in.ibm.com, ego@in.ibm.com, linuxppc-dev@ozlabs.org,
paulus@samba.org, Anton Blanchard <anton@samba.org>,
ntl@pobox.com
Subject: Re: [PATCH] Reorganise and then fixup the pseries cpu hotplug code
Date: Fri, 17 Nov 2006 12:04:57 -0600 [thread overview]
Message-ID: <20061117180456.GG23600@austin.ibm.com> (raw)
In-Reply-To: <20061117033638.0E24B67BCE@ozlabs.org>
On Fri, Nov 17, 2006 at 02:36:35PM +1100, Michael Ellerman wrote:
> The pseries cpu hotplug code is currently spread between ./kernel/rtas.c,
> ./platforms/pseries/smp.c and ./platforms/pseries/setup.c. Some of it is
> not #ifdef CONFIG_HOTPLUG_CPU, but it should be.
>
> So move all the cpu hotplug code into platforms/pseries/hotplug-cpu.c
Yes, much cleaner this way.
> + /* Isolation and deallocation are definatly done by
^^^^^^^^^
typo
> + * drslot_chrp_cpu. If they were not they would be
> + * done here. Change isolate state to Isolate and
> + * change allocation-state to Unusable.
> + */
> + paca[cpu].cpu_start = 0;
I can't figure out what the comment means with respect
to this code ...
--linas
next prev parent reply other threads:[~2006-11-17 18:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 14:39 [RFC] [PATCH] cpu hotplug on power based systems Srinivasa Ds
2006-11-16 15:40 ` Nathan Lynch
2006-11-16 21:02 ` Linas Vepstas
2006-11-17 3:36 ` [PATCH] Reorganise and then fixup the pseries cpu hotplug code Michael Ellerman
2006-11-17 3:59 ` Michael Ellerman
2006-11-17 4:31 ` Stephen Rothwell
2006-11-17 4:44 ` Michael Ellerman
2006-11-17 5:02 ` Stephen Rothwell
2006-11-17 18:11 ` Linas Vepstas
2006-11-20 0:44 ` Michael Ellerman
2006-11-17 18:04 ` Linas Vepstas [this message]
2006-11-20 1:08 ` Michael Ellerman
2006-11-20 4:22 ` jschopp
2006-11-20 5:59 ` Michael Ellerman
2006-11-21 16:43 ` Nathan Lynch
-- strict thread matches above, loose matches on Subject: below --
2006-11-23 2:11 Michael Ellerman
2006-11-24 11:03 ` Srinivasa Ds
2006-11-27 8:13 ` Srinivasa Ds
2006-11-27 21:10 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117180456.GG23600@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=anton@samba.org \
--cc=ego@in.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
--cc=srinivasa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).