From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lxorguk.ukuu.org.uk (unknown [81.2.110.250]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 0097267C7E for ; Tue, 21 Nov 2006 23:14:20 +1100 (EST) Date: Tue, 21 Nov 2006 11:49:53 +0000 From: Alan To: Akira Iguchi Subject: Re: [PATCH] drivers/ide: PATA driver for Celleb Message-ID: <20061121114953.1443e7a1@localhost.localdomain> In-Reply-To: <200611210959.kAL9x8eH026223@toshiba.co.jp> References: <200611210959.kAL9x8eH026223@toshiba.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > We use a drivers/ide driver because its design is more suitable for > SCC IDE controller than libata driver. Since SCC supports only 32bit Understand that drivers/ide will be going away at some point long term but not for a while. > read/write, we must override many callbacks of ata_port_operations > by modifying generic helpers. Each time the libata common code is > updated, we must update those modified helpers. It is very hard for us. > But we will try to implement the libata driver as needed. It would be good to do so - the future is libata. It may also help because it may indicate places were libata not your code should change in order to get a nicer interface. > +/* PIO transfer mode table */ > +/* JCHST */ > +static unsigned long JCHSTtbl[2][7] = { const... > + switch (speed) { > + case XFER_UDMA_6: > + idx = 6; > + break; These values are carefully arranged so you can do if (speed >= XFER_UDMA_0) idx = speed - XFER_UDMA_0; else return 1; Otherwise looks ready to merge. Alan