linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: ego@in.ibm.com, linuxppc-dev@ozlabs.org, srinivasa@in.ibm.com,
	Anton Blanchard <anton@samba.org>,
	paulus@samba.org
Subject: Re: [PATCH] Reorganise and then fixup the pseries cpu hotplug code
Date: Tue, 21 Nov 2006 10:43:26 -0600	[thread overview]
Message-ID: <20061121164326.GG22435@localdomain> (raw)
In-Reply-To: <1164002356.13318.4.camel@localhost.localdomain>

Michael Ellerman wrote:
> 
> OK, it didn't occur to me that it was referring to userspace. I'll
> change it to:
> 
> /*
>  * Isolation and deallocation occur in userspace, so just stop the cpu.
>  * If isolation and deallocation ever move from userpace to kernel space
>  * we would do them here.
>  */
> 
> Sound OK?

I favor just dropping the comment.  Offline and isolate are distinct
-- offline is a per-thread operation while isolate is per-processor.
Offlining a thread does not imply that its processor will be returned
to the hypervisor (e.g. going to single thread mode from SMT).

  reply	other threads:[~2006-11-21 16:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-16 14:39 [RFC] [PATCH] cpu hotplug on power based systems Srinivasa Ds
2006-11-16 15:40 ` Nathan Lynch
2006-11-16 21:02   ` Linas Vepstas
2006-11-17  3:36   ` [PATCH] Reorganise and then fixup the pseries cpu hotplug code Michael Ellerman
2006-11-17  3:59     ` Michael Ellerman
2006-11-17  4:31     ` Stephen Rothwell
2006-11-17  4:44       ` Michael Ellerman
2006-11-17  5:02         ` Stephen Rothwell
2006-11-17 18:11         ` Linas Vepstas
2006-11-20  0:44           ` Michael Ellerman
2006-11-17 18:04     ` Linas Vepstas
2006-11-20  1:08       ` Michael Ellerman
2006-11-20  4:22         ` jschopp
2006-11-20  5:59           ` Michael Ellerman
2006-11-21 16:43             ` Nathan Lynch [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-11-23  2:11 Michael Ellerman
2006-11-24 11:03 ` Srinivasa Ds
2006-11-27  8:13 ` Srinivasa Ds
2006-11-27 21:10 ` Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061121164326.GG22435@localdomain \
    --to=ntl@pobox.com \
    --cc=anton@samba.org \
    --cc=ego@in.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=srinivasa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).