* [PATCH] Provide dummy hard_irq_enable/disable() for PPC32
@ 2006-11-26 6:36 Michael Ellerman
2006-11-26 18:47 ` Rutger Nijlunsing
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2006-11-26 6:36 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev, rutger
To allow arch/powerpc/kernel/crash.c to build on 32-bit we need a
definition of hard_irq_disable(). 32-bit doesn't support the lazy
interrupt disabling mechanism, so on 32-bit hard_irq_disable() is
simply local_irq_disable(). Add a definition for hard_irq_enable()
just for completeness.
This allows (KEXEC=y && PPC32=y) to build again. Broken since
d04c56f73c30a5e593202ecfcf25ed43d42363a2.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
Paulus,
if this is OK by you, I think it should probably go in for 2.6.19.
---
include/asm-powerpc/hw_irq.h | 3 +++
1 file changed, 3 insertions(+)
Index: powerpc/include/asm-powerpc/hw_irq.h
===================================================================
--- powerpc.orig/include/asm-powerpc/hw_irq.h
+++ powerpc/include/asm-powerpc/hw_irq.h
@@ -92,6 +92,9 @@ static inline void local_irq_save_ptr(un
#define local_irq_save(flags) local_irq_save_ptr(&flags)
#define irqs_disabled() ((mfmsr() & MSR_EE) == 0)
+#define hard_irq_enable() local_irq_enable()
+#define hard_irq_disable() local_irq_disable()
+
#endif /* CONFIG_PPC64 */
#define mask_irq(irq) \
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Provide dummy hard_irq_enable/disable() for PPC32
2006-11-26 6:36 [PATCH] Provide dummy hard_irq_enable/disable() for PPC32 Michael Ellerman
@ 2006-11-26 18:47 ` Rutger Nijlunsing
0 siblings, 0 replies; 2+ messages in thread
From: Rutger Nijlunsing @ 2006-11-26 18:47 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, Paul Mackerras
On Sun, Nov 26, 2006 at 05:36:15PM +1100, Michael Ellerman wrote:
> To allow arch/powerpc/kernel/crash.c to build on 32-bit we need a
> definition of hard_irq_disable(). 32-bit doesn't support the lazy
> interrupt disabling mechanism, so on 32-bit hard_irq_disable() is
> simply local_irq_disable(). Add a definition for hard_irq_enable()
> just for completeness.
>
> This allows (KEXEC=y && PPC32=y) to build again. Broken since
> d04c56f73c30a5e593202ecfcf25ed43d42363a2.
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> ---
> Paulus,
>
> if this is OK by you, I think it should probably go in for 2.6.19.
d04c56f73c30a5e593202ecfcf25ed43d42363a2 is not in Linus' tree
currently, so no need to fix it in 2.6.19 I would say...
--
Rutger Nijlunsing ---------------------------------- eludias ed dse.nl
never attribute to a conspiracy which can be explained by incompetence
----------------------------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-26 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-26 6:36 [PATCH] Provide dummy hard_irq_enable/disable() for PPC32 Michael Ellerman
2006-11-26 18:47 ` Rutger Nijlunsing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).