From: linas@austin.ibm.com (Linas Vepstas)
To: Will Schmidt <will_schmidt@vnet.ibm.com>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH]Enabling Auto poweron after power is restored.
Date: Mon, 4 Dec 2006 13:31:14 -0600 [thread overview]
Message-ID: <20061204193114.GD4798@austin.ibm.com> (raw)
In-Reply-To: <1165247338.18104.21.camel@localhost>
On Mon, Dec 04, 2006 at 09:48:58AM -0600, Will Schmidt wrote:
>
> You could eliminate the temp variable rtas_poweron_auto_token, and
> rewrite as something like:
>
> if (rtas_token("ibm,power-off-ups") == RTAS_UNKNOWN_SERVICE) {
> rc = rtas_call(rtas_token("power-off"), 2, 1, NULL, -1, -1);
> printk(KERN_EMERG "Power-off called instead %d\n", rc );
Heh. I encouraged Manish to create the temp variable in an earlier round
of reviews. My personal taste is that nested subroutine calls are both
ugly and hard to debug, e.g. if rtas_token() for some reason returns
unexpected values, etc.
--linas
next prev parent reply other threads:[~2006-12-04 19:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 18:28 [PATCH]Enabling Auto poweron after power is restored Manish Ahuja
2006-12-04 15:48 ` Will Schmidt
2006-12-04 19:31 ` Linas Vepstas [this message]
2006-12-04 19:49 ` Olof Johansson
2006-12-04 21:26 ` Manish Ahuja
2006-12-05 21:41 ` Manish Ahuja
2006-12-08 6:09 ` Paul Mackerras
2006-12-24 16:56 ` Manish Ahuja
2006-12-24 17:50 ` Manish Ahuja
2007-01-09 4:16 ` Paul Mackerras
2007-01-09 14:21 ` Segher Boessenkool
2007-01-09 15:05 ` Nathan Lynch
2007-01-10 20:58 ` Linas Vepstas
2007-01-10 20:58 ` Manish Ahuja
2007-01-12 0:38 ` Linas Vepstas
2007-02-03 4:16 ` Manish Ahuja
2007-02-06 17:58 ` Linas Vepstas
2007-02-07 2:24 ` Paul Mackerras
2007-02-07 19:42 ` Manish Ahuja
2007-02-08 22:01 ` Manish Ahuja
2007-02-07 16:59 ` Olof Johansson
2007-02-07 17:05 ` Manish Ahuja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204193114.GD4798@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).