[PATCH] cell: fix missing spu.h header export

[PATCH] cell: fix missing spu.h header export

[Geoff Levand]

Add spu.h to the list of exported headers.  Fixes this error when
using 'make headers_check' or when CONFIG_HEADERS_CHECK=y:

  asm/spu_info.h requires asm/spu.h, which does not exist in exported headers


Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>

---
 include/asm-powerpc/Kbuild |    1 +
 1 files changed, 1 insertion(+)

--- cell--common--7.orig/include/asm-powerpc/Kbuild
+++ cell--common--7/include/asm-powerpc/Kbuild
@@ -37,6 +37,7 @@ unifdef-y += posix_types.h
 unifdef-y += ptrace.h
 unifdef-y += seccomp.h
 unifdef-y += signal.h
+unifdef-y += spu.h
 unifdef-y += termios.h
 unifdef-y += types.h
 unifdef-y += unistd.h

Re: [PATCH] cell: fix missing spu.h header export

[Arnd Bergmann]

On Tuesday 05 December 2006 22:39, Geoff Levand wrote:
>=20
> Add spu.h to the list of exported headers. =A0Fixes this error when
> using 'make headers_check' or when CONFIG_HEADERS_CHECK=3Dy:
>=20
> =A0 asm/spu_info.h requires asm/spu.h, which does not exist in exported h=
eaders
>=20
>=20
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>

Sorry, wrong fix. I had a better one already but haven't gotten around
to post it. spu_info.h should be in unifdef-y and spu.h should stay
internal to the kernel. I'll follow up with my patch.

	Arnd <><

Re: [PATCH] cell: fix missing spu.h header export

[Geoff Levand]

Arnd Bergmann wrote:
> On Tuesday 05 December 2006 22:39, Geoff Levand wrote:
>>=20
>> Add spu.h to the list of exported headers. =EF=BF=BDFixes this error w=
hen
>> using 'make headers_check' or when CONFIG_HEADERS_CHECK=3Dy:
>>=20
>> =EF=BF=BD asm/spu_info.h requires asm/spu.h, which does not exist in e=
xported headers
>>=20
>>=20
>> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
>=20
> Sorry, wrong fix. I had a better one already but haven't gotten around
> to post it. spu_info.h should be in unifdef-y and spu.h should stay
> internal to the kernel. I'll follow up with my patch.

Dang your fast, I was just going to post that!

[PATCH] cell: fix spu_info.h header export

[Arnd Bergmann]

It uses #ifdef __KERNEL__, so needs to be processes with unifdef

Signed-off-by: Arnd Bergann <arnd.bergmann@de.ibm.com>

Index: linux-2.6/include/asm-powerpc/Kbuild
===================================================================
--- linux-2.6.orig/include/asm-powerpc/Kbuild
+++ linux-2.6/include/asm-powerpc/Kbuild
@@ -17,7 +17,6 @@ header-y += ipc.h
 header-y += poll.h
 header-y += shmparam.h
 header-y += sockios.h
-header-y += spu_info.h
 header-y += ucontext.h
 header-y += ioctl.h
 header-y += linkage.h
@@ -37,6 +36,7 @@ unifdef-y += posix_types.h
 unifdef-y += ptrace.h
 unifdef-y += seccomp.h
 unifdef-y += signal.h
+unifdef-y += spu_info.h
 unifdef-y += termios.h
 unifdef-y += types.h
 unifdef-y += unistd.h

Re: [PATCH] cell: fix spu_info.h header export

[Geoff Levand]

Arnd Bergmann wrote:
> It uses #ifdef __KERNEL__, so needs to be processes with unifdef
> 
> Signed-off-by: Arnd Bergann <arnd.bergmann@de.ibm.com>

Yes, this is the proper fix.

Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>