linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] update MTD OF implementation
@ 2006-12-06 12:36 Vitaly Wool
  2006-12-11 21:58 ` Sergei Shtylyov
  0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Wool @ 2006-12-06 12:36 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev, dwmw2

Hello folks,

the patch below updates the powerpc part of the MTD OF implementation with the new field probe-type and also fixes the typos/build warning for rom.c.
So therefore it in a way supersedes the patch from Geoff which can be seen at http://ozlabs.org/pipermail/linuxppc-dev/2006-December/028831.html.

 Documentation/powerpc/booting-without-of.txt |   19 +++++++++++--------
 arch/powerpc/sysdev/rom.c                    |    1 +
 2 files changed, 12 insertions(+), 8 deletions(-)

Signed-off-by: Vitaly Wool <vwool@ru.mvista.com>

diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index b3bd366..3399427 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -1703,29 +1703,32 @@ platforms are moved over to use the flat
     Required properties:
 
      - device_type : has to be "rom"
-     - compatible : Should specify what this ROM device is compatible with
-       (i.e. "onenand"). Currently, this is most likely to be "direct-mapped"
-       (which corresponds to the MTD physmap mapping driver).
-     - regs : Offset and length of the register set (or memory mapping) for
+     - compatible : Should specify what this flash device is compatible with.
+       Currently, this is most likely to be "direct-mapped" (which
+       corresponds to the MTD physmap mapping driver).
+     - reg : Offset and length of the register set (or memory mapping) for
        the device.
+     - bank-width : Width of the flash data bus in bytes. Required
+       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
 
     Recommended properties :
 
-     - bank-width : Width of the flash data bus in bytes. Required
-       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
      - partitions : Several pairs of 32-bit values where the first value is
        partition's offset from the start of the device and the second one is
        partition size in bytes with LSB used to signify a read only
-       partititon (so, the parition size should always be an even number).
+       partition (so, the parition size should always be an even number).
      - partition-names : The list of concatenated zero terminated strings
        representing the partition names.
+     - probe-type : The type of probe which should be done for the chip
+       (JEDEC vs CFI actually). Valid ONLY for NOR flashes.
 
    Example:
 
  	flash@ff000000 {
  		device_type = "rom";
  		compatible = "direct-mapped";
- 		regs = <ff000000 01000000>;
+ 		probe-type = "CFI";
+ 		reg = <ff000000 01000000>;
  		bank-width = <4>;
  		partitions = <00000000 00f80000
  			      00f80000 00080001>;
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
diff --git a/arch/powerpc/sysdev/rom.c b/arch/powerpc/sysdev/rom.c
index bf5b3f1..c855a3b 100644
--- a/arch/powerpc/sysdev/rom.c
+++ b/arch/powerpc/sysdev/rom.c
@@ -9,6 +9,7 @@
 
 #include <linux/kernel.h>
 #include <asm/of_device.h>
+#include <asm/of_platform.h>
 
 static int __init powerpc_flash_init(void)
 {

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] update MTD OF implementation
  2006-12-06 12:36 [PATCH] update MTD OF implementation Vitaly Wool
@ 2006-12-11 21:58 ` Sergei Shtylyov
  2006-12-11 22:11   ` Vitaly Bordug
  0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2006-12-11 21:58 UTC (permalink / raw)
  To: Vitaly Wool; +Cc: linuxppc-dev, dwmw2, Paul Mackerras

Hello.

Vitaly Wool wrote:

> the patch below updates the powerpc part of the MTD OF implementation with the new field probe-type and also fixes the typos/build warning for rom.c.
> So therefore it in a way supersedes the patch from Geoff which can be seen at http://ozlabs.org/pipermail/linuxppc-dev/2006-December/028831.html.
> 
>  Documentation/powerpc/booting-without-of.txt |   19 +++++++++++--------
>  arch/powerpc/sysdev/rom.c                    |    1 +
>  2 files changed, 12 insertions(+), 8 deletions(-)
> 
> Signed-off-by: Vitaly Wool <vwool@ru.mvista.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
> index b3bd366..3399427 100644
> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -1703,29 +1703,32 @@ platforms are moved over to use the flat
>      Required properties:
>  
>       - device_type : has to be "rom"
> -     - compatible : Should specify what this ROM device is compatible with
> -       (i.e. "onenand"). Currently, this is most likely to be "direct-mapped"
> -       (which corresponds to the MTD physmap mapping driver).
> -     - regs : Offset and length of the register set (or memory mapping) for
> +     - compatible : Should specify what this flash device is compatible with.
> +       Currently, this is most likely to be "direct-mapped" (which
> +       corresponds to the MTD physmap mapping driver).
> +     - reg : Offset and length of the register set (or memory mapping) for
>         the device.
> +     - bank-width : Width of the flash data bus in bytes. Required
> +       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
>  
>      Recommended properties :
>  
> -     - bank-width : Width of the flash data bus in bytes. Required
> -       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
>       - partitions : Several pairs of 32-bit values where the first value is
>         partition's offset from the start of the device and the second one is
>         partition size in bytes with LSB used to signify a read only
> -       partititon (so, the parition size should always be an even number).
> +       partition (so, the parition size should always be an even number).
>       - partition-names : The list of concatenated zero terminated strings
>         representing the partition names.
> +     - probe-type : The type of probe which should be done for the chip
> +       (JEDEC vs CFI actually). Valid ONLY for NOR flashes.
>  
>     Example:
>  
>   	flash@ff000000 {
>   		device_type = "rom";
>   		compatible = "direct-mapped";
> - 		regs = <ff000000 01000000>;
> + 		probe-type = "CFI";
> + 		reg = <ff000000 01000000>;
>   		bank-width = <4>;
>   		partitions = <00000000 00f80000
>   			      00f80000 00080001>;
> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
> diff --git a/arch/powerpc/sysdev/rom.c b/arch/powerpc/sysdev/rom.c
> index bf5b3f1..c855a3b 100644
> --- a/arch/powerpc/sysdev/rom.c
> +++ b/arch/powerpc/sysdev/rom.c
> @@ -9,6 +9,7 @@
>  
>  #include <linux/kernel.h>
>  #include <asm/of_device.h>
> +#include <asm/of_platform.h>
>  
>  static int __init powerpc_flash_init(void)
>  {

WBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] update MTD OF implementation
  2006-12-11 21:58 ` Sergei Shtylyov
@ 2006-12-11 22:11   ` Vitaly Bordug
  0 siblings, 0 replies; 3+ messages in thread
From: Vitaly Bordug @ 2006-12-11 22:11 UTC (permalink / raw)
  Cc: linuxppc-dev, dwmw2, Paul Mackerras

[-- Attachment #1: Type: text/plain, Size: 3861 bytes --]

On Tue, 12 Dec 2006 00:58:29 +0300
Sergei Shtylyov wrote:

> Hello.
> 
> Vitaly Wool wrote:
> 
> > the patch below updates the powerpc part of the MTD OF
> > implementation with the new field probe-type and also fixes the
> > typos/build warning for rom.c. So therefore it in a way supersedes
> > the patch from Geoff which can be seen at
> > http://ozlabs.org/pipermail/linuxppc-dev/2006-December/028831.html.
> > 
> >  Documentation/powerpc/booting-without-of.txt |   19
> > +++++++++++-------- arch/powerpc/sysdev/rom.c
> > |    1 + 2 files changed, 12 insertions(+), 8 deletions(-)
> > 
> > Signed-off-by: Vitaly Wool <vwool@ru.mvista.com>
> 
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Vitaly Bordug <vitb@kernel.crashing.org>


> 
> > diff --git a/Documentation/powerpc/booting-without-of.txt
> > b/Documentation/powerpc/booting-without-of.txt index
> > b3bd366..3399427 100644 ---
> > a/Documentation/powerpc/booting-without-of.txt +++
> > b/Documentation/powerpc/booting-without-of.txt @@ -1703,29 +1703,32
> > @@ platforms are moved over to use the flat Required properties:
> >  
> >       - device_type : has to be "rom"
> > -     - compatible : Should specify what this ROM device is
> > compatible with
> > -       (i.e. "onenand"). Currently, this is most likely to be
> > "direct-mapped"
> > -       (which corresponds to the MTD physmap mapping driver).
> > -     - regs : Offset and length of the register set (or memory
> > mapping) for
> > +     - compatible : Should specify what this flash device is
> > compatible with.
> > +       Currently, this is most likely to be "direct-mapped" (which
> > +       corresponds to the MTD physmap mapping driver).
> > +     - reg : Offset and length of the register set (or memory
> > mapping) for the device.
> > +     - bank-width : Width of the flash data bus in bytes. Required
> > +       for the NOR flashes (compatible == "direct-mapped" and
> > others) ONLY. 
> >      Recommended properties :
> >  
> > -     - bank-width : Width of the flash data bus in bytes. Required
> > -       for the NOR flashes (compatible == "direct-mapped" and
> > others) ONLY.
> >       - partitions : Several pairs of 32-bit values where the first
> > value is partition's offset from the start of the device and the
> > second one is partition size in bytes with LSB used to signify a
> > read only
> > -       partititon (so, the parition size should always be an even
> > number).
> > +       partition (so, the parition size should always be an even
> > number).
> >       - partition-names : The list of concatenated zero terminated
> > strings representing the partition names.
> > +     - probe-type : The type of probe which should be done for the
> > chip
> > +       (JEDEC vs CFI actually). Valid ONLY for NOR flashes.
> >  
> >     Example:
> >  
> >   	flash@ff000000 {
> >   		device_type = "rom";
> >   		compatible = "direct-mapped";
> > - 		regs = <ff000000 01000000>;
> > + 		probe-type = "CFI";
> > + 		reg = <ff000000 01000000>;
> >   		bank-width = <4>;
> >   		partitions = <00000000 00f80000
> >   			      00f80000 00080001>;
> > diff --git a/arch/powerpc/sysdev/Makefile
> > b/arch/powerpc/sysdev/Makefile diff --git
> > a/arch/powerpc/sysdev/rom.c b/arch/powerpc/sysdev/rom.c index
> > bf5b3f1..c855a3b 100644 --- a/arch/powerpc/sysdev/rom.c
> > +++ b/arch/powerpc/sysdev/rom.c
> > @@ -9,6 +9,7 @@
> >  
> >  #include <linux/kernel.h>
> >  #include <asm/of_device.h>
> > +#include <asm/of_platform.h>
> >  
> >  static int __init powerpc_flash_init(void)
> >  {
> 
> WBR, Sergei
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev


-- 
Sincerely, Vitaly


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-11 22:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-06 12:36 [PATCH] update MTD OF implementation Vitaly Wool
2006-12-11 21:58 ` Sergei Shtylyov
2006-12-11 22:11   ` Vitaly Bordug

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).