From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.177]) by ozlabs.org (Postfix) with ESMTP id A9D1767BE8 for ; Wed, 13 Dec 2006 07:03:45 +1100 (EST) From: Arnd Bergmann To: linuxppc-dev@ozlabs.org Subject: Re: [PATCH 8/15] Supporting PCI bus and base of I/O Date: Tue, 12 Dec 2006 21:03:41 +0100 References: <200612120338.kBC3c08S020556@toshiba.co.jp> In-Reply-To: <200612120338.kBC3c08S020556@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200612122103.41597.arnd@arndb.de> Cc: paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday 12 December 2006 04:37, Ishizaki Kou wrote: > This patch includes support for pci buses, base of Celleb specific > devices, and etc. It works on of_platform bus. > > Signed-off-by: Kou Ishizaki The code looks good to me, I guess it could go in, except that I really don't like the concept of faking a PCI bus device when it's not actually there. I guess the EPCI part of this is not controversial, so it would be good if you can split that out into a separate patch that we can merge first. Arnd <><