From: linas@austin.ibm.com (Linas Vepstas)
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: linux-ide@vger.kernel.org, paulus@samba.org, arnd@arndb.de,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] drivers/ata: PATA driver for Celleb
Date: Tue, 12 Dec 2006 17:34:21 -0600 [thread overview]
Message-ID: <20061212233421.GM4329@austin.ibm.com> (raw)
In-Reply-To: <200612120206.kBC26wHr022838@toshiba.co.jp>
On Tue, Dec 12, 2006 at 11:08:24AM +0900, Akira Iguchi wrote:
>
> I use some static functions in libata-core.c because it makes
You will want to split this patch into several pars, and submit the
changes to libata-core.c separately.
> --- linux-2.6.19/drivers/ata/libata-core.c Wed Dec 6 12:00:47 2006
> ***************
> *** 600,606 ****
> * Device type - %ATA_DEV_ATA, %ATA_DEV_ATAPI or %ATA_DEV_NONE.
> */
>
> ! static unsigned int
> ata_dev_try_classify(struct ata_port *ap, unsigned int device, u8 *r_err)
> {
> struct ata_taskfile tf;
> --- 600,606 ----
> * Device type - %ATA_DEV_ATA, %ATA_DEV_ATAPI or %ATA_DEV_NONE.
> */
>
> ! unsigned int
> ata_dev_try_classify(struct ata_port *ap, unsigned int device, u8 *r_err)
Please generate unified diffs (diff -pu) or use quilt,
this makes the patches easier to read. (and smaller)
--linas
prev parent reply other threads:[~2006-12-12 23:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 2:08 [PATCH] drivers/ata: PATA driver for Celleb Akira Iguchi
2006-12-12 23:34 ` Linas Vepstas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212233421.GM4329@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=akira2.iguchi@toshiba.co.jp \
--cc=arnd@arndb.de \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).