From: Michael Ellerman <michael@ellerman.id.au>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org
Subject: [PATCH 7/9] MPIC MSI backend
Date: Wed, 13 Dec 2006 21:40:06 +1100 [thread overview]
Message-ID: <20061213104015.85E7E67CD6@ozlabs.org> (raw)
In-Reply-To: <1166006370.90082.476088563252.qpush@cradle>
MPIC MSI backend. Based on code from Segher, heavily hacked by me.
Renamed to mpic_htmsi, as it only deals with MSI over Hypertransport.
We properly discover the HT magic address by reading the config space.
Now have an irq allocator we can support > 1 MSI, and we don't reuse
the LSI.
Tested, succesfully getting MSIs from the tg3 via HT/PCI-X on a JS21
running SLOF. Successive insmod/rmmods working too.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
arch/powerpc/sysdev/Makefile | 2
arch/powerpc/sysdev/mpic.h | 7 +
arch/powerpc/sysdev/mpic_htmsi.c | 193 +++++++++++++++++++++++++++++++++++++++
3 files changed, 201 insertions(+), 1 deletion(-)
Index: msi/arch/powerpc/sysdev/Makefile
===================================================================
--- msi.orig/arch/powerpc/sysdev/Makefile
+++ msi/arch/powerpc/sysdev/Makefile
@@ -3,7 +3,7 @@ EXTRA_CFLAGS += -mno-minimal-toc
endif
mpic-obj-y := mpic.o
-mpic-obj-$(CONFIG_PCI_MSI) += mpic_msi.o
+mpic-obj-$(CONFIG_PCI_MSI) += mpic_msi.o mpic_htmsi.o
obj-$(CONFIG_MPIC) += $(mpic-obj-y)
obj-$(CONFIG_PPC_INDIRECT_PCI) += indirect_pci.o
Index: msi/arch/powerpc/sysdev/mpic.h
===================================================================
--- msi.orig/arch/powerpc/sysdev/mpic.h
+++ msi/arch/powerpc/sysdev/mpic.h
@@ -15,11 +15,18 @@
#include <asm/msi.h>
#ifdef CONFIG_PCI_MSI
+extern int mpic_htmsi_init(struct mpic *mpic);
+
extern int mpic_msi_init_allocator(struct mpic *mpic);
extern void mpic_msi_reserve_hwirq(struct mpic *mpic, irq_hw_number_t hwirq);
extern irq_hw_number_t mpic_msi_alloc_hwirqs(struct mpic *mpic, int num);
extern void mpic_msi_free_hwirqs(struct mpic *mpic, int offset, int num);
#else
+static inline int mpic_htmsi_init(struct mpic *mpic)
+{
+ return -1;
+}
+
static inline void mpic_msi_reserve_hwirq(struct mpic *mpic,
irq_hw_number_t hwirq)
{
Index: msi/arch/powerpc/sysdev/mpic_htmsi.c
===================================================================
--- /dev/null
+++ msi/arch/powerpc/sysdev/mpic_htmsi.c
@@ -0,0 +1,193 @@
+/*
+ * Copyright (C) 2006 Segher Boessenkool, IBM Corp.
+ * Copyright (C) 2006 Michael Ellerman, IBM Corp.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; version 2 of the
+ * License.
+ *
+ */
+
+#undef DEBUG
+
+#include <linux/irq.h>
+#include <linux/bootmem.h>
+#include <asm/msi.h>
+#include <asm/mpic.h>
+#include <asm/prom.h>
+#include <asm/hw_irq.h>
+#include <asm/ppc-pci.h>
+
+#include "mpic.h"
+
+/* XXX Do we ever need > 1 of these? void * msi_ops.data perhaps ? */
+static struct mpic *msi_mpic;
+
+static unsigned int find_ht_msi_capability(struct pci_dev *pdev)
+{
+ unsigned int pos = pci_find_capability(pdev, PCI_CAP_ID_HT);
+ u8 subcap, ttl = 48;
+
+ while (pos && ttl--) {
+ pci_read_config_byte(pdev, pos + 3, &subcap);
+ if ((subcap & 0xF8) == HT_CAPTYPE_MSI_MAPPING)
+ return pos;
+ pos = pci_find_next_capability(pdev, pos, PCI_CAP_ID_HT);
+ }
+
+ return 0;
+}
+
+static u64 read_ht_magic_addr(struct pci_dev *pdev, unsigned int pos)
+{
+ u8 flags;
+ u32 tmp;
+ u64 addr;
+
+ pci_read_config_byte(pdev, pos + HT_MSI_FLAGS, &flags);
+
+ if (flags & HT_MSI_FLAGS_FIXED)
+ return HT_MSI_FIXED_ADDR;
+
+ pci_read_config_dword(pdev, pos + HT_MSI_ADDR_LO, &tmp);
+ addr = tmp & HT_MSI_ADDR_LO_MASK;
+ pci_read_config_dword(pdev, pos + HT_MSI_ADDR_HI, &tmp);
+ addr = addr | ((u64)tmp << 32);
+
+ return addr;
+}
+
+static u64 find_ht_magic_addr(struct pci_dev *pdev)
+{
+ struct pci_bus *bus;
+ unsigned int pos;
+
+ for (bus = pdev->bus; bus; bus = bus->parent) {
+ pos = find_ht_msi_capability(bus->self);
+ if (pos)
+ return read_ht_magic_addr(bus->self, pos);
+ }
+
+ return 0;
+}
+
+static int htmsi_check(struct pci_dev *pdev, int num,
+ struct msix_entry *entries, int type)
+{
+ if (type == PCI_CAP_ID_MSIX) {
+ msi_debug("MSI-X unsupported for %s\n", pci_name(pdev));
+ return 1;
+ }
+
+ /* If we can't find a magic address then MSI ain't gonna work */
+ if (find_ht_magic_addr(pdev) == 0) {
+ msi_debug("no magic address found for %s\n", pci_name(pdev));
+ return 1;
+ }
+
+ return 0;
+}
+
+static void htmsi_free(struct pci_dev *pdev, int num,
+ struct msix_entry *entries, int type)
+{
+ irq_hw_number_t hwirq;
+ int i;
+
+ hwirq = irq_map[entries[0].vector].hwirq;
+
+ for (i = 0; i < num; i++) {
+ irq_dispose_mapping(entries[i].vector);
+ entries[i].vector = NO_IRQ;
+ }
+
+ msi_debug("freeing %d hwirqs for msi at offset 0x%lx\n", num, hwirq);
+ mpic_msi_free_hwirqs(msi_mpic, hwirq, num);
+
+ return;
+}
+
+static int htmsi_alloc(struct pci_dev *pdev, int num,
+ struct msix_entry *entries, int type)
+{
+ int i;
+ irq_hw_number_t hwirq;
+ unsigned int virq;
+
+ hwirq = mpic_msi_alloc_hwirqs(msi_mpic, num);
+ if (hwirq < 0) {
+ msi_debug("failed allocating %d hwirqs for %s\n", num,
+ pci_name(pdev));
+ return -1;
+ }
+
+ for (i = 0; i < num; i++) {
+ /* FIXME should we save the existing type */
+ set_irq_type(hwirq, IRQ_TYPE_EDGE_RISING);
+
+ virq = irq_create_mapping(msi_mpic->irqhost, hwirq);
+ if (virq == NO_IRQ) {
+ msi_debug("failed mapping hwirq 0x%lx for %s\n", hwirq,
+ pci_name(pdev));
+ goto out_free;
+ }
+
+ entries[i].vector = virq;
+ hwirq++;
+ }
+
+ return 0;
+
+ out_free:
+ htmsi_free(pdev, num, entries, type);
+ return -1;
+}
+
+static int htmsi_setup_msi_msg(struct pci_dev *pdev,
+ struct msix_entry *entry, struct msi_msg *msg, int type)
+{
+ u64 addr;
+
+ addr = find_ht_magic_addr(pdev);
+ msg->address_lo = addr & 0xFFFFFFFF;
+ msg->address_hi = addr >> 32;
+ msg->data = irq_map[entry->vector].hwirq;
+
+ msi_debug("allocated irq %d at 0x%lx for %s\n", entry->vector,
+ addr, pci_name(pdev));
+
+ return 0;
+}
+
+static struct ppc_msi_ops mpic_htmsi_ops = {
+ .check = htmsi_check,
+ .alloc = htmsi_alloc,
+ .free = htmsi_free,
+ .enable = msi_raw_enable,
+ .disable = msi_raw_disable,
+ .setup_msi_msg = htmsi_setup_msi_msg,
+};
+
+static struct ppc_msi_ops *htmsi_get_msi_ops(struct pci_dev *pdev)
+{
+ return &mpic_htmsi_ops;
+}
+
+int mpic_htmsi_init(struct mpic *mpic)
+{
+ int rc;
+
+ rc = mpic_msi_init_allocator(mpic);
+ if (rc) {
+ pr_debug("mpic_htmsi_init: Error allocating bitmap!\n");
+ return rc;
+ }
+
+ msi_mpic = mpic;
+
+ pr_debug("mpic_htmsi_init: Registering MPIC MSI ops.\n");
+ ppc_md.get_msi_ops = htmsi_get_msi_ops;
+
+ return 0;
+}
next prev parent reply other threads:[~2006-12-13 10:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 10:39 [PATCH 0/9] Powerpc MSI Implementation (.. again) Michael Ellerman
2006-12-13 10:39 ` [PATCH 1/9] Add #defines for Hypertransport MSI fields Michael Ellerman
2006-12-13 10:39 ` [PATCH 2/9] Rip out the existing powerpc msi stubs Michael Ellerman
2006-12-13 10:39 ` [PATCH 3/9] Powerpc MSI implementation Michael Ellerman
2006-12-13 10:39 ` [PATCH 4/9] Enable MSI on Powerpc Michael Ellerman
2006-12-13 10:39 ` [PATCH 5/9] RTAS MSI implementation Michael Ellerman
2006-12-13 10:40 ` [PATCH 6/9] MPIC MSI allocator Michael Ellerman
2006-12-13 18:23 ` Olof Johansson
2006-12-13 23:25 ` Benjamin Herrenschmidt
2006-12-14 0:09 ` Olof Johansson
2006-12-14 0:32 ` Benjamin Herrenschmidt
2006-12-14 0:59 ` Michael Ellerman
2006-12-14 1:02 ` Benjamin Herrenschmidt
2006-12-14 1:06 ` Michael Ellerman
2006-12-14 14:46 ` Segher Boessenkool
2006-12-14 19:44 ` Benjamin Herrenschmidt
2006-12-15 1:47 ` Segher Boessenkool
2006-12-15 1:51 ` Michael Ellerman
2006-12-15 2:28 ` Benjamin Herrenschmidt
2006-12-15 2:58 ` Segher Boessenkool
2006-12-15 6:42 ` Olof Johansson
2006-12-14 1:06 ` Olof Johansson
2006-12-14 0:34 ` Michael Ellerman
2006-12-13 10:40 ` Michael Ellerman [this message]
2006-12-13 10:40 ` [PATCH 8/9] Activate MSI on Powerpc Michael Ellerman
2006-12-13 10:40 ` [PATCH 9/9] Enable MSI mappings for MPIC Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213104015.85E7E67CD6@ozlabs.org \
--to=michael@ellerman.id.au \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).