From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id 5793367B77 for ; Wed, 13 Dec 2006 19:34:59 +1100 (EST) Date: Wed, 13 Dec 2006 11:35:05 +0300 From: Vitaly Bordug To: Kumar Gala Subject: Re: [PATCH 1/4] [POWERPC] cpm2: Updates for CPM2 pic Message-ID: <20061213113505.6d5d90fd@vitb.ru.mvista.com> In-Reply-To: References: <20061212012641.5ef493f7@localhost.localdomain> <20061211223659.20169.50415.stgit@localhost.localdomain> <20061212215509.696cccf8@vitb.ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 12 Dec 2006 13:58:44 -0600 Kumar Gala wrote: > > On Dec 12, 2006, at 12:55 PM, Vitaly Bordug wrote: > > > On Mon, 11 Dec 2006 20:21:52 -0600 > > Kumar Gala wrote: > > > >> > >> On Dec 11, 2006, at 4:36 PM, Vitaly Bordug wrote: > >> > >>> > >>> This contains important fixes for the CPM2 PIC code. Eliminated > >>> CPM_IRQ_OFFSET, pulling the respective interrupt numbers from the > >>> interrupt > >>> mapping. Updated devicetree files to reflect that. Changed direct > >>> IC-related IO accesses to the IO accessors. > >> > >> Since your changing the interrupt numbers, do you mind changing the > >> interrupt sense to match ipic? I was hoping to introduce a generic > >> host_xlate function to cover the various embedded pic's. > > Umm, can you pls elaborate what do you want to achieve? > > Its a minor thing, but the values we picked for ipic to encode sense/ > polarity match the linux definitions. The idea is that if we use > the same encoding on multiple pic's we can sure the host_xlate code. > I started it but faced with the problem: in 8560, there are both mpic and cpm2 pic. To keep consistency (so that cpm irqs encode sence one way, and generic - mpic - in another), we'll have to modify mpic too, and all the 85xx dts's as well. Yet doable, it's pretty big change, and I think it should be put to the patch, independent of small fixes I have introduced, and that should come separately (or else we'll have hard time git-bisecting for troubles). If you envision this way as a proper one for mpic too, I'll head for it though. -- Sincerely, Vitaly