From: Johannes Berg <johannes@sipsolutions.net>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH 1/3] windfarm: dont die on suspend thread signal
Date: Wed, 13 Dec 2006 13:38:20 +0100 [thread overview]
Message-ID: <20061213123944.747406000@sipsolutions.net> (raw)
In-Reply-To: 20061213123819.403286000@sipsolutions.net
When the windfarm thread gets a suspend signal it will die instead of
freezing. This fixes it.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
--- linux-2.6-git.orig/drivers/macintosh/windfarm_core.c 2006-12-11 23:34:47.082716759 +0100
+++ linux-2.6-git/drivers/macintosh/windfarm_core.c 2006-12-11 23:37:58.181716759 +0100
@@ -93,8 +93,6 @@ static int wf_thread_func(void *data)
DBG("wf: thread started\n");
while(!kthread_should_stop()) {
- try_to_freeze();
-
if (time_after_eq(jiffies, next)) {
wf_notify(WF_EVENT_TICK, NULL);
if (wf_overtemp) {
@@ -117,8 +115,8 @@ static int wf_thread_func(void *data)
if (delay <= HZ)
schedule_timeout_interruptible(delay);
- /* there should be no signal, but oh well */
- if (signal_pending(current)) {
+ /* there should be no non-suspend signal, but oh well */
+ if (signal_pending(current) && !try_to_freeze()) {
printk(KERN_WARNING "windfarm: thread got sigl !\n");
break;
}
--
next prev parent reply other threads:[~2006-12-13 13:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 12:38 [PATCH 0/3] some preparations for suspend on G5 powermac Johannes Berg
2006-12-13 12:38 ` Johannes Berg [this message]
2007-01-24 6:32 ` [PATCH 1/3] windfarm: dont die on suspend thread signal Benjamin Herrenschmidt
2006-12-13 12:38 ` [PATCH 2/3] powermac: proper time of day after resume Johannes Berg
2007-01-24 6:34 ` Benjamin Herrenschmidt
2007-01-24 8:46 ` Johannes Berg
2007-01-24 8:51 ` Benjamin Herrenschmidt
2007-01-24 8:54 ` Gabriel Paubert
2007-01-24 9:32 ` Benjamin Herrenschmidt
2007-01-24 10:36 ` Gabriel Paubert
2007-01-24 14:23 ` Segher Boessenkool
2007-01-24 21:44 ` Benjamin Herrenschmidt
2007-01-24 22:24 ` Segher Boessenkool
2007-01-24 22:35 ` Benjamin Herrenschmidt
2007-01-24 23:21 ` Segher Boessenkool
2007-01-25 7:39 ` Michel Dänzer
2007-01-25 8:06 ` Benjamin Herrenschmidt
2007-01-25 8:10 ` Michel Dänzer
2007-01-25 11:09 ` Gabriel Paubert
2007-01-25 12:54 ` Johannes Berg
2007-01-26 14:35 ` Johannes Berg
2007-02-01 19:16 ` [PATCH] " Johannes Berg
2007-02-02 12:19 ` Johannes Berg
2007-02-03 2:41 ` Michael Ellerman
2007-02-03 17:37 ` Johannes Berg
2007-05-02 4:45 ` Paul Mackerras
2007-05-02 4:47 ` Paul Mackerras
2007-05-02 8:26 ` Johannes Berg
2007-05-02 14:25 ` [PATCH] powerpc timer sysdev: use mktime Johannes Berg
2007-05-23 15:28 ` Johannes Berg
2007-05-28 4:33 ` Paul Mackerras
2006-12-13 12:38 ` [PATCH 3/3] powerpc: fix comment in kernel/irq.c Johannes Berg
2006-12-13 13:13 ` Johannes Berg
2006-12-19 5:40 ` Paul Mackerras
2006-12-19 18:29 ` Johannes Berg
2007-01-24 6:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213123944.747406000@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).