From: Arnd Bergmann <arnd@arndb.de>
To: Mike Kravetz <kravetz@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hch@infradead.org, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>,
Michael Kravetz <mkravetz@us.ibm.com>,
cbe-oss-dev@ozlabs.org
Subject: Re: Bug: early_pfn_in_nid() called when not early
Date: Thu, 14 Dec 2006 00:37:51 +0100 [thread overview]
Message-ID: <200612140037.53477.arnd@arndb.de> (raw)
In-Reply-To: <20061213231717.GC10708@monkey.ibm.com>
On Thursday 14 December 2006 00:17, Mike Kravetz wrote:
> Thanks for the debug work! =A0Just curious if you really need
> CONFIG_NODES_SPAN_OTHER_NODES defined for your platform? =A0Can you get
> those types of memory layouts? =A0If not, an easy/immediate fix for you
> might be to simply turn off the option.
We want to be able to run the same kernel as pseries, e.g. on
distributions that ship only one kernel. Cell should be able to
live without CONFIG_NODES_SPAN_OTHER_NODES, but that does not solve
the problem for us.
> > --- linux-2.6.orig/mm/page_alloc.c
> > +++ linux-2.6/mm/page_alloc.c
> > @@ -1962,7 +1962,8 @@ void __meminit memmap_init_zone(unsigned
> > =A0=A0=A0=A0=A0=A0for (pfn =3D start_pfn; pfn < end_pfn; pfn++) {
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (!early_pfn_valid(pfn))
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0conti=
nue;
> > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (!early_pfn_in_nid(pfn, nid))
> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (!slab_is_available() &&
> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0!early_pfn_in_nid(pfn, =
nid))
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0conti=
nue;
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0page =3D pfn_to_page(pfn);
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0set_page_links(page, zone, ni=
d, pfn);
>=20
> I know you don't recommend this as a fix, but it has the interesting
> quality of doing exactly what we want for powerpc. =A0When
> slab_is_available() we are performing a 'memory add' operation
> and there is no need to do the 'pfn_in_nid' check. =A0We know that
> the range of added pages will all be on the same (passed) nid.
Right, that was at least my intention, though I wasn't sure
if pseries can live without the check.
Arnd <><
next prev parent reply other threads:[~2006-12-13 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 18:20 Bug: early_pfn_in_nid() called when not early Arnd Bergmann
2006-12-13 23:17 ` Mike Kravetz
2006-12-13 23:21 ` Benjamin Herrenschmidt
2006-12-13 23:37 ` Arnd Bergmann [this message]
2006-12-13 23:58 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612140037.53477.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=hch@infradead.org \
--cc=kravetz@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mkravetz@us.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).