From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 18 Dec 2006 22:15:34 +0000 From: Christoph Hellwig To: Dave Hansen Subject: Re: [PATCH] Fix sparsemem on Cell Message-ID: <20061218221534.GB25472@infradead.org> References: <20061215165335.61D9F775@localhost.localdomain> <4582D756.7090702@shadowen.org> <1166203440.8105.22.camel@localhost.localdomain> <20061215114536.dc5c93af.akpm@osdl.org> <20061216170353.2dfa27b1.kamezawa.hiroyu@jp.fujitsu.com> <1166476437.8648.7.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1166476437.8648.7.camel@localhost.localdomain> Cc: Andrew Morton , linux-mm@kvack.org, kmannth@us.ibm.com, linux-kernel@vger.kernel.org, hch@infradead.org, linuxppc-dev@ozlabs.org, paulus@samba.org, mkravetz@us.ibm.com, gone@us.ibm.com, cbe-oss-dev@ozlabs.org, KAMEZAWA Hiroyuki List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Dec 18, 2006 at 01:13:57PM -0800, Dave Hansen wrote: > On Sat, 2006-12-16 at 17:03 +0900, KAMEZAWA Hiroyuki wrote: > > /* add this memory to iomem resource */ > > static struct resource *register_memory_resource(u64 start, u64 size) > > { > > @@ -273,10 +284,13 @@ > > if (ret) > > goto error; > > } > > + atomic_inc(&memory_hotadd_count); > > > > /* call arch's memory hotadd */ > > ret = arch_add_memory(nid, start, size); > > > > + atomic_dec(&memory_hotadd_count); > > I'd be willing to be that this will work just fine. But, I think we can > do it without any static state at all, if we just pass a runtime-or-not > flag down into the arch_add_memory() call chain. > > I'll code that up so we can compare to yours. Yes, I stronly concur that passing an explicit flag is much much better than any hack involving global state.