From: Christian Krafft <krafft@de.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Christian Krafft <krafft@linux.ibm.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
openipmi-developer@lists.sourceforge.net
Subject: Re: [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree
Date: Tue, 19 Dec 2006 14:12:45 +0100 [thread overview]
Message-ID: <20061219141245.679caa11@localhost> (raw)
In-Reply-To: <A45F8443-A031-41AC-887C-669FABBE0F09@kernel.crashing.org>
On Mon, 18 Dec 2006 22:52:07 +0100
Segher Boessenkool <segher@kernel.crashing.org> wrote:
>=20
> info->io_regsize =3D regsize ? *regsize : DEFAULT_REGSIZE;
>=20
> [Please note that fixes a copy/paste bug, too].
There is no DEFAULT_REGSIZE, all the code is using DEFAULT_REGSPACING as th=
e default size.
It looks like the code assumes that the registers are located next to each =
other.
If thats not good, DEFAULT_REGSIZE should be introduced and used in all oth=
er probe functions as well.
That would be a seperate issue .
>=20
>=20
> Segher
>=20
--=20
Mit freundlichen Gr=FCssen,
kind regards,
Christian Krafft
IBM Systems & Technology Group,=20
Linux Kernel Development
IT Specialist
next prev parent reply other threads:[~2006-12-19 13:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061218163846.337fed65@localhost>
2006-12-18 15:42 ` [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree Christian Krafft
2006-12-18 21:52 ` Segher Boessenkool
2006-12-18 22:23 ` Arnd Bergmann
2006-12-19 17:48 ` Segher Boessenkool
2006-12-19 18:06 ` [Openipmi-developer] " Corey Minyard
2006-12-19 13:12 ` Christian Krafft [this message]
2006-12-19 17:52 ` Segher Boessenkool
2006-12-19 18:01 ` Corey Minyard
2006-12-20 14:45 ` [patch 0/1] updated version Christian Krafft
2006-12-21 0:11 ` Arnd Bergmann
2007-01-24 23:45 ` [patch 1/1] updated version, fixed the compiler warning Christian Krafft
2007-01-24 23:56 ` Benjamin Herrenschmidt
2007-01-25 0:29 ` Segher Boessenkool
2007-01-25 0:45 ` Christian Krafft
2007-01-25 0:45 ` Benjamin Herrenschmidt
2007-01-25 1:05 ` Segher Boessenkool
2007-01-25 3:14 ` Arnd Bergmann
2007-01-25 0:24 ` Segher Boessenkool
2007-01-25 3:30 ` [patch 0/1] next updated version, fixed cleanup and some minors Christian Krafft
2007-01-25 3:34 ` [patch 1/1] " Christian Krafft
2007-01-25 5:19 ` Arnd Bergmann
2007-01-29 3:49 ` [Openipmi-developer] " Corey Minyard
2007-01-26 2:54 ` [patch 1/1] updated version, fixed the compiler warning Christoph Hellwig
2007-01-26 4:23 ` Arnd Bergmann
2007-01-28 23:07 ` Christian Krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219141245.679caa11@localhost \
--to=krafft@de.ibm.com \
--cc=arnd@arndb.de \
--cc=krafft@linux.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).