From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] sound: aoa of_node_put and kfree cleanup
Date: Tue, 2 Jan 2007 13:50:57 +0100 [thread overview]
Message-ID: <200701021350.57816.m.kozlowski@tuxland.pl> (raw)
Hello,
This patch removes redundant argument checks for of_node_put() and kfree().
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
sound/aoa/fabrics/snd-aoa-fabric-layout.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -upr linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c
--- linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c 2006-12-28 12:57:54.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c 2007-01-02 01:50:26.000000000 +0100
@@ -1034,9 +1034,9 @@ static int aoa_fabric_layout_probe(struc
list_del(&ldev->list);
layouts_list_items--;
outnodev:
- if (sound) of_node_put(sound);
+ of_node_put(sound);
layout_device = NULL;
- if (ldev) kfree(ldev);
+ kfree(ldev);
return -ENODEV;
}
--
Regards,
Mariusz Kozlowski
next reply other threads:[~2007-01-02 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 12:50 Mariusz Kozlowski [this message]
2007-01-02 13:12 ` [PATCH] sound: aoa of_node_put and kfree cleanup Johannes Berg
2007-01-08 11:21 ` [Alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701021350.57816.m.kozlowski@tuxland.pl \
--to=m.kozlowski@tuxland.pl \
--cc=alsa-devel@alsa-project.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).