linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic
Date: Wed, 10 Jan 2007 08:09:49 +0300	[thread overview]
Message-ID: <20070110080949.5a0bf1a7@localhost.localdomain> (raw)
In-Reply-To: <17828.19395.906600.586578@cargo.ozlabs.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2232 bytes --]

On Wed, 10 Jan 2007 13:13:23 +1100
Paul Mackerras wrote:

> Vitaly Bordug writes:
> > 
> > This contains important fixes for the CPM2 PIC code. Eliminated
> > CPM_IRQ_OFFSET, pulling the respective interrupt numbers from the
> > interrupt mapping. Updated devicetree files to reflect that.
> > Changed direct IC-related IO accesses to the IO accessors.
> 
> I can't put these patches in for 2.6.20 with the titles and
> descriptions you have given.
> 
well that is to say, mpc8272 is utterly broken without patch 1, as interrupt controller will not work at all.
8560's cpm2-related will be hosed too (hence no uart, heh)

> At this stage, for stuff to go into 2.6.20, you need to clearly
> identify what the problem is that you're fixing and give at least some
> indication of why it needs to be fixed for 2.6.20.  If the code
> currently won't compile at all for some config, or is now completely
> wrong because of changes elsewhere, or could cause an oops, then we
> can fix it, but I need something better than just "Updates" in the
> title and a list of what changes you made in the description.  At the
> moment I look at your patch titles and descriptions and think "that's
> nice, but why should it go in 2.6.20?"
> 

OK. I'll update descriptions and resubmit

> If you're fixing up something that worked in 2.6.19 but now doesn't
> work, that helps justify the change, but you need to say that.
> 
> These comments apply particularly to patches 1 to 3 in your series.
> For patch 4/5 you at least told us that changes to io.h caused the
> breakage, but even there a bit more detail about what changes caused
> what breakage would be useful.  However, at this stage, you need to
> resist the temptation to do other "overhaul and improvements" while
> you are there; just fix the bugs or breakages that you have identified
> in the description.
> 
All above is quite right, however  patch 4 does not contain extra code iirc (that do not address breakages),
I just kept same description it used to have at initial revision, submitted during merge window. 

> Patch 5/5 is OK since it doesn't touch any actual code
> 
Thanks for looking over this stuff such promptly...

> Paul.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-01-10  5:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-10  1:11 [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic Vitaly Bordug
2007-01-10  1:11 ` [PATCH 2/5] [POWERPC] cpm_uart: OF-related updates Vitaly Bordug
2007-01-10  1:11 ` [PATCH 3/5] [FS_ENET] OF-related update for FEC and SCC MAC's Vitaly Bordug
2007-01-10 17:07   ` Kumar Gala
2007-01-10 20:14     ` Vitaly Bordug
2007-01-10  1:12 ` [PATCH 4/5] [POWERPC] Fix kernel build errors for mpc8272ads and mpc8560ads Vitaly Bordug
2007-01-10 17:11   ` Kumar Gala
2007-01-10 20:50     ` Vitaly Bordug
2007-01-10 20:58       ` Kumar Gala
2007-01-10 21:41         ` Vitaly Bordug
2007-01-10  1:12 ` [PATCH 5/5] [POWERPC] mpc8272ads: defconfig Vitaly Bordug
2007-01-10  2:13 ` [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic Paul Mackerras
2007-01-10  5:09   ` Vitaly Bordug [this message]
2007-01-10 17:02 ` Kumar Gala
2007-01-10 20:13   ` Vitaly Bordug
2007-01-10 20:55     ` Kumar Gala
2007-01-10 20:58       ` Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070110080949.5a0bf1a7@localhost.localdomain \
    --to=vbordug@ru.mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).