From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic
Date: Wed, 10 Jan 2007 23:58:26 +0300 [thread overview]
Message-ID: <20070110235826.2ac91a41@localhost.localdomain> (raw)
In-Reply-To: <21AA3C6D-75E2-4A5D-852A-5D745CA2C5FF@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]
On Wed, 10 Jan 2007 14:55:04 -0600
Kumar Gala wrote:
>
> On Jan 10, 2007, at 2:13 PM, Vitaly Bordug wrote:
>
> > On Wed, 10 Jan 2007 11:02:52 -0600
> > Kumar Gala wrote:
> >
> >>
> >> On Jan 9, 2007, at 7:11 PM, Vitaly Bordug wrote:
> >>
> >>>
> >>> This contains important fixes for the CPM2 PIC code. Eliminated
> >>> CPM_IRQ_OFFSET, pulling the respective interrupt numbers from the
> >>> interrupt
> >>> mapping. Updated devicetree files to reflect that. Changed direct
> >>> IC-related IO accesses to the IO accessors.
> >>>
> >>> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
> >>> ---
> >>
> >> [snip]
> >>
> >>> diff --git a/include/asm-powerpc/mpc8260.h b/include/asm-powerpc/
> >>> mpc8260.h
> >>> new file mode 100644
> >>> index 0000000..c2adcb0
> >>> --- /dev/null
> >>> +++ b/include/asm-powerpc/mpc8260.h
> >>> @@ -0,0 +1,32 @@
> >>> +/*
> >>> + * Since there are many different boards and no standard
> >>> configuration,
> >>> + * we have a unique include file for each. Rather than change
> >>> every
> >>> + * file that has to include MPC8260 configuration, they all
> >>> include
> >>> + * this one and the configuration switching is done here.
> >>> + */
> >>> +#ifdef __KERNEL__
> >>> +#ifndef __ASM_PPC_MPC8260_H__
> >>> +#define __ASM_PPC_MPC8260_H__
> >>> +
> >>> +
> >>> +#ifdef CONFIG_8260
> >>> +
> >>> +#if defined(CONFIG_PQ2ADS) || defined (CONFIG_PQ2FADS)
> >>> +#include <platforms/82xx/pq2ads.h>
> >>> +#endif
> >>
> >> What's defined in pq2ads.h that is needed by other code?
> >>
> > holding CPM_MAP_ADDR -- not everywhere in the current code it
> > could be pulled from the devtree.
> > Actually, I have it addressed, but that is pretty big mod that
> > could not be called bugfix and will hopefully be merged in next
> > window.
>
> Ok, do you mind adding a comment about that so we make sure it gets
> cleaned up for 2.6.21
>
Will do, not a big deal since I have the actual patch already :)
--
-Vitaly
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-01-10 20:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 1:11 [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic Vitaly Bordug
2007-01-10 1:11 ` [PATCH 2/5] [POWERPC] cpm_uart: OF-related updates Vitaly Bordug
2007-01-10 1:11 ` [PATCH 3/5] [FS_ENET] OF-related update for FEC and SCC MAC's Vitaly Bordug
2007-01-10 17:07 ` Kumar Gala
2007-01-10 20:14 ` Vitaly Bordug
2007-01-10 1:12 ` [PATCH 4/5] [POWERPC] Fix kernel build errors for mpc8272ads and mpc8560ads Vitaly Bordug
2007-01-10 17:11 ` Kumar Gala
2007-01-10 20:50 ` Vitaly Bordug
2007-01-10 20:58 ` Kumar Gala
2007-01-10 21:41 ` Vitaly Bordug
2007-01-10 1:12 ` [PATCH 5/5] [POWERPC] mpc8272ads: defconfig Vitaly Bordug
2007-01-10 2:13 ` [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic Paul Mackerras
2007-01-10 5:09 ` Vitaly Bordug
2007-01-10 17:02 ` Kumar Gala
2007-01-10 20:13 ` Vitaly Bordug
2007-01-10 20:55 ` Kumar Gala
2007-01-10 20:58 ` Vitaly Bordug [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070110235826.2ac91a41@localhost.localdomain \
--to=vbordug@ru.mvista.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).