From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id 500E5DDE2D for ; Thu, 11 Jan 2007 07:59:58 +1100 (EST) Date: Wed, 10 Jan 2007 23:58:26 +0300 From: Vitaly Bordug To: Kumar Gala Subject: Re: [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic Message-ID: <20070110235826.2ac91a41@localhost.localdomain> In-Reply-To: <21AA3C6D-75E2-4A5D-852A-5D745CA2C5FF@kernel.crashing.org> References: <20070110011124.20342.38130.stgit@localhost.localdomain> <20070110231322.12c8add7@localhost.localdomain> <21AA3C6D-75E2-4A5D-852A-5D745CA2C5FF@kernel.crashing.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_sBhBue5=648RXnV4937cMH3"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: linuxppc-dev , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --Sig_sBhBue5=648RXnV4937cMH3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 10 Jan 2007 14:55:04 -0600 Kumar Gala wrote: >=20 > On Jan 10, 2007, at 2:13 PM, Vitaly Bordug wrote: >=20 > > On Wed, 10 Jan 2007 11:02:52 -0600 > > Kumar Gala wrote: > > > >> > >> On Jan 9, 2007, at 7:11 PM, Vitaly Bordug wrote: > >> > >>> > >>> This contains important fixes for the CPM2 PIC code. Eliminated > >>> CPM_IRQ_OFFSET, pulling the respective interrupt numbers from the > >>> interrupt > >>> mapping. Updated devicetree files to reflect that. Changed direct > >>> IC-related IO accesses to the IO accessors. > >>> > >>> Signed-off-by: Vitaly Bordug > >>> --- > >> > >> [snip] > >> > >>> diff --git a/include/asm-powerpc/mpc8260.h b/include/asm-powerpc/ > >>> mpc8260.h > >>> new file mode 100644 > >>> index 0000000..c2adcb0 > >>> --- /dev/null > >>> +++ b/include/asm-powerpc/mpc8260.h > >>> @@ -0,0 +1,32 @@ > >>> +/* > >>> + * Since there are many different boards and no standard > >>> configuration, > >>> + * we have a unique include file for each. Rather than change > >>> every > >>> + * file that has to include MPC8260 configuration, they all > >>> include > >>> + * this one and the configuration switching is done here. > >>> + */ > >>> +#ifdef __KERNEL__ > >>> +#ifndef __ASM_PPC_MPC8260_H__ > >>> +#define __ASM_PPC_MPC8260_H__ > >>> + > >>> + > >>> +#ifdef CONFIG_8260 > >>> + > >>> +#if defined(CONFIG_PQ2ADS) || defined (CONFIG_PQ2FADS) > >>> +#include > >>> +#endif > >> > >> What's defined in pq2ads.h that is needed by other code? > >> > > holding CPM_MAP_ADDR -- not everywhere in the current code it > > could be pulled from the devtree. > > Actually, I have it addressed, but that is pretty big mod that =20 > > could not be called bugfix and will hopefully be merged in next =20 > > window. >=20 > Ok, do you mind adding a comment about that so we make sure it gets =20 > cleaned up for 2.6.21 >=20 Will do, not a big deal since I have the actual patch already :) -- -Vitaly --Sig_sBhBue5=648RXnV4937cMH3 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFFpVNyuOg9JvQhSEsRAkb9AJ9FCfhPq4OhteLHqW4LK9Z1V9PlPQCgn6tA 4aYIEpwLXCXpOKHn3jmBuzU= =rS7H -----END PGP SIGNATURE----- --Sig_sBhBue5=648RXnV4937cMH3--