From: Olof Johansson <olof@lixom.net>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] atomic_dec_if_positive sign extension fix
Date: Sun, 14 Jan 2007 17:20:13 -0600 [thread overview]
Message-ID: <20070114172013.57329bbf@localhost.localdomain> (raw)
In-Reply-To: <17834.47158.581922.62728@cargo.ozlabs.ibm.com>
On Mon, 15 Jan 2007 10:09:42 +1100 Paul Mackerras <paulus@samba.org> wrote:
> NAK: Good fix for 64-bit, but it will break 32-bit. I think a better
> fix would be to use a cmpwi after the lwarx, and use addi rather than
> addic..
Good point, I forgot about that when I suggested extsw to Rob.
Seems like spinlock.h solves the same problem by using a
__DO_SIGN_EXTEND define instead. Should we keep logic common as much as
possible and use the same method in atomic.h?
-Olof
next prev parent reply other threads:[~2007-01-14 23:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 22:55 [PATCH] atomic_dec_if_positive sign extension fix Robert Jennings
2007-01-14 23:09 ` Paul Mackerras
2007-01-14 23:20 ` Olof Johansson [this message]
2007-01-14 23:32 ` Segher Boessenkool
2007-01-14 23:43 ` Segher Boessenkool
2007-01-15 8:55 ` Gabriel Paubert
2007-01-15 16:01 ` Segher Boessenkool
2007-01-16 4:28 ` Gabriel Paubert
2007-01-16 8:36 ` Segher Boessenkool
2007-01-16 18:16 ` [PATCH][v2] " Robert Jennings
2007-01-16 20:08 ` Gabriel Paubert
2007-01-17 16:50 ` [PATCH][v3] " Robert Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070114172013.57329bbf@localhost.localdomain \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).