From: Gabriel Paubert <paubert@iram.es>
To: Robert Jennings <rcj@linux.vnet.ibm.com>
Cc: olof@lixom.net, linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH][v2] atomic_dec_if_positive sign extension fix
Date: Tue, 16 Jan 2007 21:08:38 +0100 [thread overview]
Message-ID: <20070116200838.GA22381@iram.es> (raw)
In-Reply-To: <20070116181604.GA24756@austin.ibm.com>
On Tue, Jan 16, 2007 at 12:16:05PM -0600, Robert Jennings wrote:
> Paul,
>
> Here is v.2 for the patch.
> Please apply for 2.6.20. If an atomic counter is explicitly set to a
> negative value the atomic_dec_if_positive function will decrement and
> store the next smallest value in the atomic counter contrary to it's
> intended operation.
>
> The comparison to determine if the decrement will make the result
> negative is done by the "addic." operation which operates on a 64-bit
> value. I've changed the addic to an addi (changing "=&r" to "=&g" in
I think the proper constraint is "=&b".
Gabriel
next prev parent reply other threads:[~2007-01-16 20:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 22:55 [PATCH] atomic_dec_if_positive sign extension fix Robert Jennings
2007-01-14 23:09 ` Paul Mackerras
2007-01-14 23:20 ` Olof Johansson
2007-01-14 23:32 ` Segher Boessenkool
2007-01-14 23:43 ` Segher Boessenkool
2007-01-15 8:55 ` Gabriel Paubert
2007-01-15 16:01 ` Segher Boessenkool
2007-01-16 4:28 ` Gabriel Paubert
2007-01-16 8:36 ` Segher Boessenkool
2007-01-16 18:16 ` [PATCH][v2] " Robert Jennings
2007-01-16 20:08 ` Gabriel Paubert [this message]
2007-01-17 16:50 ` [PATCH][v3] " Robert Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070116200838.GA22381@iram.es \
--to=paubert@iram.es \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).