From: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 13/19] powerpc: Supporting iommu for Celleb
Date: Thu, 18 Jan 2007 21:10:06 +0900 (JST) [thread overview]
Message-ID: <200701181210.l0ICA69c008115@toshiba.co.jp> (raw)
In-Reply-To: <1169080280.4965.21.camel@localhost.localdomain>
Ben-san,
Thank you for your comment.
> > +static int __init celleb_init_iommu(void)
> > +{
>
> This needs a:
>
> if (!machine_is(celleb))
> return 0;
>
> Since the initcall will always be called wether your platform was
> selected at boot or not as long as it's built into the kernel.
We will fix it.
Best regards,
Kou Ishizaki
next prev parent reply other threads:[~2007-01-18 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 1:13 [PATCH 13/19] powerpc: Supporting iommu for Celleb Ishizaki Kou
2007-01-18 0:31 ` Benjamin Herrenschmidt
2007-01-18 12:10 ` Ishizaki Kou [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-14 2:43 Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701181210.l0ICA69c008115@toshiba.co.jp \
--to=kou.ishizaki@toshiba.co.jp \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox