MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

[Russell McGuire]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

All,

 

Attempting to compile the kernel with that latest DENX-2.6 tree from git.

I have started with the MPC834x_defconfig and added a few options, but now
when I compile

 

arch/ppc/boot/common/ns16550.c  error: 'SERIAL_PORT_DFNS' undeclared here ..

 

I can see clearly this is defined in /include/asm-ppc/serial.h

 

But why isn't this being included?

 

I am more inclined to think this is an option I have not included in my
.config file, does anyone have idea what this might be?

I do have defined 8250/16550 char/serial devices selected in the menuconfig.


 

Or is this something that changed with the newest patches?

 

I don't seem to recall having this problem with 2.6.15 that shipped with
ELDK_4.0, but then again I might have had different compile options defined.


 

Has anyone else seen his error?

 

-Russ


[-- Attachment #2: Type: text/html, Size: 4677 bytes --]

Re: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

[Ben Warren]

Russell,

On Fri, 2007-01-19 at 11:28 -0800, Russell McGuire wrote:

> 
> arch/ppc/boot/common/ns16550.c  error: ‘SERIAL_PORT_DFNS’ undeclared
> here ……
> 

I don't think you should be building any code there...  Are you using
ARCH=powerpc (you should be)

regards,
Ben

RE: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

[Russell McGuire]

Ben,

That could be the problem

I am building using ARCH=ppc

What is the difference between the two?

-----Original Message-----
From: Ben Warren [mailto:bwarren@qstreams.com] 
Sent: Friday, January 19, 2007 11:58 AM
To: Russell McGuire
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?


Russell,

On Fri, 2007-01-19 at 11:28 -0800, Russell McGuire wrote:

> 
> arch/ppc/boot/common/ns16550.c  error: 'SERIAL_PORT_DFNS' undeclared
> here ..
> 

I don't think you should be building any code there...  Are you using
ARCH=powerpc (you should be)

regards,
Ben

RE: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

[Ben Warren]

On Fri, 2007-01-19 at 12:14 -0800, Russell McGuire wrote:
> Ben,
> 
> That could be the problem
> 
> I am building using ARCH=ppc
> 
> What is the difference between the two?
> 
I'm not by any means the expert, but I believe that ARCH=powerpc is a
merge of 32 and 64 bit PowerPC architectures (plus all sorts of
relatives like POWER and cell), and is where 'everybody' is moving.
Many types of processors (including 83xx) have been fully transitioned
to powerpc, while others are in the works.  There are a few differences
that you'd notice, especially the requirement for passing hardware
information via device tree in ARCH=powerpc.  I don't know if ARCH=ppc
is going away for 83xx, but it isn't being maintained or updated, AFAIK.

With ARCH=powerpc, you will hopefully be able to get your board booting
soon, assuming your device tree is correct enough.

regards,
Ben

Re: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

[Vitaly Bordug]

[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]

On Fri, 19 Jan 2007 12:14:04 -0800
Russell McGuire wrote:

> Ben,
> 
> That could be the problem
> 
> I am building using ARCH=ppc
> 
> What is the difference between the two?
Newer targets appear within arch/powerpc... Concerning your question, 
you seem to add new board hence you'll have to do those SERIAL_PORT_DFNS
in board-specific header file - grep for them inside arch/ppc for reference (if
that code is still there of course).

OTOH, if you are able to replace/update your firmware, I'd follow powerpc way.
Difference is FAQ I guess, please look around this list.

> 
> -----Original Message-----
And, uhm, top quoting is not good. I know telling that fact to Lookout DIstress is a challenge but anyway :)

--
Thanks, Vitaly
> From: Ben Warren [mailto:bwarren@qstreams.com] 
> Sent: Friday, January 19, 2007 11:58 AM
> To: Russell McGuire
> Cc: linuxppc-embedded@ozlabs.org
> Subject: Re: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?
> 
> 
> Russell,
> 
> On Fri, 2007-01-19 at 11:28 -0800, Russell McGuire wrote:
> 
> > 
> > arch/ppc/boot/common/ns16550.c  error: 'SERIAL_PORT_DFNS' undeclared
> > here ..
> > 
> 
> I don't think you should be building any code there...  Are you using
> ARCH=powerpc (you should be)
> 
> regards,
> Ben
> 
> 
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

[Benjamin Herrenschmidt]

On Fri, 2007-01-19 at 23:34 +0300, Vitaly Bordug wrote:
> On Fri, 19 Jan 2007 12:14:04 -0800
> Russell McGuire wrote:
> 
> > Ben,
> > 
> > That could be the problem
> > 
> > I am building using ARCH=ppc
> > 
> > What is the difference between the two?
> Newer targets appear within arch/powerpc... Concerning your question, 
> you seem to add new board hence you'll have to do those SERIAL_PORT_DFNS
> in board-specific header file - grep for them inside arch/ppc for reference (if
> that code is still there of course).

Note that SERIAL_PORT_DFNS are pretty much deprecated too :-) Nobody
cared fixing arch/ppc but for arch/powerpc, you should use one of the
new mecanisms, if possible using the device-tree / platform devices.

Ben.

Re: MPC83xx: ns16550.c - 'SERIAL_PORT_DFNS' undeclared?

[Timur Tabi]

Russell McGuire wrote:
> Ben,
> 
> That could be the problem
> 
> I am building using ARCH=ppc
> 
> What is the difference between the two?

Short answer: ppc is deprecated in favor of powerpc.

Eventually, ppc will go away altogether.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale