From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: paulus@samba.org
Subject: Re: [PATCH 5/14] ps3: rename interrupt symbols
Date: Thu, 25 Jan 2007 07:00:45 +0100 [thread overview]
Message-ID: <200701250700.45997.arnd@arndb.de> (raw)
In-Reply-To: <1169697011.24996.47.camel@localhost.localdomain>
On Thursday 25 January 2007 04:50, Benjamin Herrenschmidt wrote:
> On Wed, 2007-01-24 at 18:39 -0800, Geoff Levand wrote:
> > Rename some PS3 interrupt symbols to avoid name clashes and aid debugging.
> > No change to code.
> >
> > Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
>
> Might be even better to do
>
> struct ps3_irq_bitmap
> struct ps3_irq_priv
>
> But that's already better than what was there before. Nice to see you
> seem to agree with my initial rant about those names :-)
Right.
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
prev parent reply other threads:[~2007-01-25 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 2:39 [PATCH 5/14] ps3: rename interrupt symbols Geoff Levand
2007-01-25 3:50 ` Benjamin Herrenschmidt
2007-01-25 6:00 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701250700.45997.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).