From: Christoph Hellwig <hch@lst.de>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 1/14] ps3: repository misc fixes
Date: Fri, 26 Jan 2007 04:01:13 +0100 [thread overview]
Message-ID: <20070126030113.GF18537@lst.de> (raw)
In-Reply-To: <20070126025741.GD18537@lst.de>
On Fri, Jan 26, 2007 at 03:57:41AM +0100, Christoph Hellwig wrote:
> On Wed, Jan 24, 2007 at 06:39:37PM -0800, Geoff Levand wrote:
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_id);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_type);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_num_dev);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_id);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_type);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_intr);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_find_device);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_info);
>
> > +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_region);
>
>
> Exporting all these as procedural interfaces is very wrong. Please
> implement a proper bustype for your hypervisor devices where all this
> information is an attribute of the hv1_device object.
In addition to that there's no user of these exports in this patch,
so there is no point in adding any kind of export for this type of
information at all yet. (until we have a proper storage driver)
next prev parent reply other threads:[~2007-01-26 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 2:39 [PATCH 1/14] ps3: repository misc fixes Geoff Levand
2007-01-25 5:56 ` Arnd Bergmann
2007-01-26 2:57 ` Christoph Hellwig
2007-01-26 3:01 ` Christoph Hellwig [this message]
2007-01-26 20:39 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126030113.GF18537@lst.de \
--to=hch@lst.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).