From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lst.de (verein.lst.de [213.95.11.210]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id BAA9BDE031 for ; Fri, 26 Jan 2007 14:01:20 +1100 (EST) Date: Fri, 26 Jan 2007 04:01:13 +0100 From: Christoph Hellwig To: Geoff Levand Subject: Re: [PATCH 1/14] ps3: repository misc fixes Message-ID: <20070126030113.GF18537@lst.de> References: <45B81869.6070305@am.sony.com> <20070126025741.GD18537@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070126025741.GD18537@lst.de> Cc: Geert Uytterhoeven , linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jan 26, 2007 at 03:57:41AM +0100, Christoph Hellwig wrote: > On Wed, Jan 24, 2007 at 06:39:37PM -0800, Geoff Levand wrote: > > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_id); > > > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_type); > > > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_num_dev); > > > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_id); > > > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_type); > > > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_intr); > > > +EXPORT_SYMBOL_GPL(ps3_repository_find_device); > > > +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_info); > > > +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_region); > > > Exporting all these as procedural interfaces is very wrong. Please > implement a proper bustype for your hypervisor devices where all this > information is an attribute of the hv1_device object. In addition to that there's no user of these exports in this patch, so there is no point in adding any kind of export for this type of information at all yet. (until we have a proper storage driver)