From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Paul Mackerras <paulus@samba.org>,
James Simmons <jsimmons@infradead.org>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>,
Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 8/9] ps3: cleanup ps3fb before clearing HPTE
Date: Fri, 26 Jan 2007 04:14:38 +0100 [thread overview]
Message-ID: <20070126031438.GH18537@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0701251851160.24610@pademelon.sonytel.be>
On Thu, Jan 25, 2007 at 06:51:50PM +0100, Geert Uytterhoeven wrote:
> PS3: Cleanup the frame buffer device before clearing the HPTE mapping
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
> arch/powerpc/platforms/ps3/htab.c | 5 +++++
> 1 files changed, 5 insertions(+)
>
> --- ps3-linux.orig/arch/powerpc/platforms/ps3/htab.c
> +++ ps3-linux/arch/powerpc/platforms/ps3/htab.c
> @@ -234,6 +234,11 @@ static void ps3_hpte_invalidate(unsigned
>
> static void ps3_hpte_clear(void)
> {
> + extern void ps3fb_cleanup(void);
Externs belong into headers.
> +
> +#ifdef CONFIG_FB_PS3
> + ps3fb_cleanup();
> +#endif
And well, adding framebuffer calls into the mmu code is rather fucked.
This at least needs a big comment explaning the hypervisor braindamage
that is responsible for this in colourfull language.
next prev parent reply other threads:[~2007-01-26 3:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 17:46 [PATCH 0/9] ps3av/fb drivers for 2.6.21 Geert Uytterhoeven
2007-01-25 17:48 ` [PATCH 1/9] ps3: AV Settings Driver Geert Uytterhoeven
2007-01-26 3:12 ` Christoph Hellwig
2007-01-29 14:10 ` Geert Uytterhoeven
2007-01-29 16:15 ` Christoph Hellwig
2007-01-29 19:24 ` Geoff Levand
2007-01-30 18:39 ` Segher Boessenkool
2007-01-30 19:39 ` Geert Uytterhoeven
2007-01-31 8:45 ` Christoph Hellwig
2007-01-26 4:13 ` Arnd Bergmann
2007-01-26 14:56 ` Geert Uytterhoeven
2007-01-28 21:37 ` Benjamin Herrenschmidt
2007-01-29 15:14 ` Geert Uytterhoeven
2007-01-30 0:16 ` Arnd Bergmann
2007-01-25 17:48 ` [PATCH 2/9] fbdev modedb: allow refresh rates for named video modes Geert Uytterhoeven
2007-01-25 17:49 ` [PATCH 3/9] fbdev modedb: make more pointer parameters const Geert Uytterhoeven
2007-01-25 17:49 ` [PATCH 4/9] fb_videomode_to_var: reset virtual screen parameters Geert Uytterhoeven
2007-01-25 17:50 ` [PATCH 5/9] ps3: Preallocate bootmem memory for ps3fb Geert Uytterhoeven
2007-01-30 2:29 ` Michael Ellerman
2007-01-30 8:16 ` Geert Uytterhoeven
2007-01-30 8:27 ` Arnd Bergmann
2007-01-30 8:36 ` Geert Uytterhoeven
2007-01-30 9:08 ` Benjamin Herrenschmidt
2007-01-30 10:44 ` Arnd Bergmann
2007-01-30 22:37 ` Michael Ellerman
2007-01-25 17:50 ` [PATCH 6/9] ps3: Virtual Frame Buffer Driver Geert Uytterhoeven
2007-01-25 21:36 ` [Linux-fbdev-devel] " Bernhard Fischer
2007-01-25 17:51 ` [PATCH 7/9] ps3: disable display flipping during mode changes Geert Uytterhoeven
2007-01-26 2:13 ` Arnd Bergmann
2007-01-25 17:51 ` [PATCH 8/9] ps3: cleanup ps3fb before clearing HPTE Geert Uytterhoeven
2007-01-26 3:14 ` Christoph Hellwig [this message]
2007-01-30 2:23 ` Michael Ellerman
2007-03-24 23:46 ` Geoff Levand
2007-03-25 17:43 ` Milton Miller
2007-03-27 1:06 ` Geoff Levand
2007-03-27 17:35 ` Christoph Hellwig
2007-01-25 17:52 ` [PATCH 9/9] ps3: ps3av/fb defconfig updates Geert Uytterhoeven
2007-01-25 17:55 ` [PATCH 0/9] ps3av/fb drivers for 2.6.21 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126031438.GH18537@lst.de \
--to=hch@lst.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).