From: linas@austin.ibm.com (Linas Vepstas)
To: Jens Osterkamp <jens@de.ibm.com>
Cc: netdev@vger.kernel.org, cbe-oss-dev@ozlabs.org,
linuxppc-dev@ozlabs.org, jgarzik@pobox.com,
James K Lewis <jim@jklewis.com>
Subject: Re: spidernet: dynamic phy setup code
Date: Fri, 26 Jan 2007 11:58:37 -0600 [thread overview]
Message-ID: <20070126175837.GB8489@austin.ibm.com> (raw)
In-Reply-To: <200701261409.29537.jens@de.ibm.com>
On Fri, Jan 26, 2007 at 02:09:29PM +0100, Jens Osterkamp wrote:
> This patch modifies the patch submitted by Kou Ishizaki to make it work on the
> blade (http://marc.theaimsgroup.com/?l=linux-netdev&m=116593424505539&w=2).
>
> Index: linux-2.6/drivers/net/spider_net.c
> + if (card->aneg_count > SPIDER_NET_ANEG_TIMEOUT) {
> +
> + pr_info("%s: link is down, trying to bring it up\n", card->netdev->name);
> +
> + switch(phy->medium) {
> + case GMII_COPPER:
> + /* enable fiber with autonegotiation first */
> + if (phy->def->ops->enable_fiber)
> + phy->def->ops->enable_fiber(phy, 1);
> + phy->medium = GMII_FIBER;
> + break;
Can you fix this to use tabs for indentation, instead of spaces?
Please note, if you do not like tabs of 8 spaces, you can always
change this in your editor, e.g "set ts=3" for making a tab
be 3 spaces in vi. You would put this in your .exrc or .vimrc file.
Patches submitted to the kernel should use tabs, uniformly.
--linas
next prev parent reply other threads:[~2007-01-26 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 13:09 spidernet: dynamic phy setup code Jens Osterkamp
2007-01-26 17:58 ` Linas Vepstas [this message]
[not found] ` <200701262150.52882.jens@de.ibm.com>
2007-01-26 22:15 ` Linas Vepstas
2007-01-26 22:30 ` Jens Osterkamp
2007-01-26 20:21 ` Benjamin Herrenschmidt
2007-02-01 10:50 ` Jens Osterkamp
2007-02-01 8:05 ` [Cbe-oss-dev] " Ishizaki Kou
2007-02-01 11:04 ` Jens Osterkamp
2007-02-02 10:20 ` Ishizaki Kou
2007-02-05 0:08 ` Benjamin Herrenschmidt
2007-02-02 10:29 ` [RFC/PATCH 2.6.20-rc6 1/4] spidernet: autoneg support for Celleb Ishizaki Kou
2007-02-02 10:30 ` [RFC/PATCH 2.6.20-rc6 2/4] spidernet: load firmaware when open Ishizaki Kou
2007-02-02 10:31 ` [RFC/PATCH 2.6.20-rc6 3/4] spidernet: add support for Celleb Ishizaki Kou
2007-02-02 10:33 ` [RFC/PATCH 2.6.20-rc6 4/4] spidernet: remove txram full logging Ishizaki Kou
2007-02-04 23:44 ` [Cbe-oss-dev] spidernet: dynamic phy setup code Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-02-01 7:54 kou.ishizaki
2007-02-06 10:42 ` spidernet: dynamic phy setup code Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126175837.GB8489@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=jens@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=jim@jklewis.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).