From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 4/16] ps3: system bus minor mmio fix
Date: Sun, 28 Jan 2007 09:42:40 +0100 [thread overview]
Message-ID: <20070128084239.GA6311@lst.de> (raw)
In-Reply-To: <1169928417.24996.205.camel@localhost.localdomain>
On Sun, Jan 28, 2007 at 07:06:57AM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2007-01-26 at 19:07 -0800, Geoff Levand wrote:
> > From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >
> > Fix two minor bugs in the PS3 system bus mmio region code. First, on error or
> > when freeing a region, retain the bus_addr and len fields to allow subsequent
> > calls to create the region. Second, correct the region address argument to the
> > lv1_unmap_device_mmio_region() call.
>
> Note that I personally think that drivers/ps3 is a very wrong place for
> the ps3 system bus. It should stay in arch/powerpc/platform/ps3
Yes, absolutely. We should not spreads things all over the tree do
make understanding the code even more difficult than all the lv1
braindamage already makes it.
next prev parent reply other threads:[~2007-01-28 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-27 3:07 [PATCH 4/16] ps3: system bus minor mmio fix Geoff Levand
2007-01-27 20:06 ` Benjamin Herrenschmidt
2007-01-28 8:42 ` Christoph Hellwig [this message]
2007-01-29 19:32 ` Geoff Levand
2007-01-29 20:16 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070128084239.GA6311@lst.de \
--to=hch@lst.de \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).