linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Paul Mackerras <paulus@samba.org>,
	Linux Frame Buffer Device Development
	<linux-fbdev-devel@lists.sourceforge.net>,
	James Simmons <jsimmons@infradead.org>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/9] ps3: AV Settings Driver
Date: Mon, 29 Jan 2007 17:15:02 +0100	[thread overview]
Message-ID: <20070129161502.GA32313@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0701291442530.19906@pademelon.sonytel.be>

On Mon, Jan 29, 2007 at 03:10:16PM +0100, Geert Uytterhoeven wrote:
> On Fri, 26 Jan 2007, Christoph Hellwig wrote:
> > Btw, the Kconfig and/or top of file comment really needs a better
> > explanation what this "driver" is for.  I also wonder why it's
> 
> What about `PS3 AV settings driver library' instead of `PS3 AV controller
> support'?

Makes a little more sense, yes.

> We can make FB_PS3 (and SND_PS3 later) select PS3_PS3AV. Is that better?
> I prefer not to make it unconditional, as people who want to run their PS3s
> headless don't need it.

Ok.  Even better would be handling it on the makefile level, by doing

obj-$(CONFIG_FB_PS3)	+= ps3_av.o
obj-$(CONFIG_SND_PS3)	+= ps3_av.o

> I guess you want us to do the same for the virtual uart, i.e. let PS3_PS3AV and
> PS3_SYS_MANAGER select PS3_VUART?

Yes, that probably makes sense aswell.

  reply	other threads:[~2007-01-29 16:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 17:46 [PATCH 0/9] ps3av/fb drivers for 2.6.21 Geert Uytterhoeven
2007-01-25 17:48 ` [PATCH 1/9] ps3: AV Settings Driver Geert Uytterhoeven
2007-01-26  3:12   ` Christoph Hellwig
2007-01-29 14:10     ` Geert Uytterhoeven
2007-01-29 16:15       ` Christoph Hellwig [this message]
2007-01-29 19:24         ` Geoff Levand
2007-01-30 18:39         ` Segher Boessenkool
2007-01-30 19:39           ` Geert Uytterhoeven
2007-01-31  8:45           ` Christoph Hellwig
2007-01-26  4:13   ` Arnd Bergmann
2007-01-26 14:56     ` Geert Uytterhoeven
2007-01-28 21:37       ` Benjamin Herrenschmidt
2007-01-29 15:14     ` Geert Uytterhoeven
2007-01-30  0:16       ` Arnd Bergmann
2007-01-25 17:48 ` [PATCH 2/9] fbdev modedb: allow refresh rates for named video modes Geert Uytterhoeven
2007-01-25 17:49 ` [PATCH 3/9] fbdev modedb: make more pointer parameters const Geert Uytterhoeven
2007-01-25 17:49 ` [PATCH 4/9] fb_videomode_to_var: reset virtual screen parameters Geert Uytterhoeven
2007-01-25 17:50 ` [PATCH 5/9] ps3: Preallocate bootmem memory for ps3fb Geert Uytterhoeven
2007-01-30  2:29   ` Michael Ellerman
2007-01-30  8:16     ` Geert Uytterhoeven
2007-01-30  8:27       ` Arnd Bergmann
2007-01-30  8:36         ` Geert Uytterhoeven
2007-01-30  9:08           ` Benjamin Herrenschmidt
2007-01-30 10:44             ` Arnd Bergmann
2007-01-30 22:37       ` Michael Ellerman
2007-01-25 17:50 ` [PATCH 6/9] ps3: Virtual Frame Buffer Driver Geert Uytterhoeven
2007-01-25 21:36   ` [Linux-fbdev-devel] " Bernhard Fischer
2007-01-25 17:51 ` [PATCH 7/9] ps3: disable display flipping during mode changes Geert Uytterhoeven
2007-01-26  2:13   ` Arnd Bergmann
2007-01-25 17:51 ` [PATCH 8/9] ps3: cleanup ps3fb before clearing HPTE Geert Uytterhoeven
2007-01-26  3:14   ` Christoph Hellwig
2007-01-30  2:23     ` Michael Ellerman
2007-03-24 23:46     ` Geoff Levand
2007-03-25 17:43       ` Milton Miller
2007-03-27  1:06         ` Geoff Levand
2007-03-27 17:35       ` Christoph Hellwig
2007-01-25 17:52 ` [PATCH 9/9] ps3: ps3av/fb defconfig updates Geert Uytterhoeven
2007-01-25 17:55 ` [PATCH 0/9] ps3av/fb drivers for 2.6.21 Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070129161502.GA32313@lst.de \
    --to=hch@lst.de \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).