From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
prasanna@in.ibm.com
Subject: Re: RFC: kprobes support for ppc32
Date: Tue, 30 Jan 2007 17:03:16 +0530 [thread overview]
Message-ID: <20070130113316.GA17288@in.ibm.com> (raw)
In-Reply-To: <20070130104630.GC14571@lst.de>
On Tue, Jan 30, 2007 at 11:46:30AM +0100, Christoph Hellwig wrote:
> On Tue, Jan 30, 2007 at 12:13:32AM -0600, Kumar Gala wrote:
> > + depends on !BOOKE && KALLSYMS && EXPERIMENTAL && MODULES
>
> Just curious: what's the problem with BOOKE?
>
> > +#ifdef CONFIG_PPC64
> > regs->nip = (unsigned long)(((func_descr_t *)jp->entry)->entry);
> > regs->gpr[2] = (unsigned long)(((func_descr_t *)jp->entry)->toc);
> > +#else
> > + regs->nip = (unsigned long)jp->entry;
> > +#endif
>
> This should probably be split int a macro.
>
>
>
> also I think you should not define kprobe_lookup_name for the 32bit
> case as the generic version should be fine for ppc32
Right. 32bit powerpc uses the SVR4 ABI and hence can just use the
generic version. In addition, since 32bit powerpc implementations don't
have a TD/TDI, they can be stubbed out too in the is_trap() check.
Ananth
next prev parent reply other threads:[~2007-01-30 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 6:13 RFC: kprobes support for ppc32 Kumar Gala
2007-01-30 6:24 ` Ananth N Mavinakayanahalli
2007-01-30 10:46 ` Christoph Hellwig
2007-01-30 11:33 ` Ananth N Mavinakayanahalli [this message]
2007-01-30 14:45 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130113316.GA17288@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).