From: Nathan Lynch <ntl@pobox.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] rename pSeries nvram functions
Date: Tue, 30 Jan 2007 14:16:42 -0600 [thread overview]
Message-ID: <20070130201642.GJ9045@localdomain> (raw)
In-Reply-To: <1169696480.24996.40.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Wed, 2007-01-24 at 19:00 -0600, Nathan Lynch wrote:
> > Benjamin Herrenschmidt wrote:
> > > On Thu, 2007-01-25 at 11:46 +1100, Benjamin Herrenschmidt wrote:
> > > > On Wed, 2007-01-24 at 18:16 -0600, Nathan Lynch wrote:
> > > > > The nvram support in the pSeries platform code is not really tied to
> > > > > the pSeries platform. This code is useful on other platforms that
> > > > > have the necessary firmware support.
> > > > >
> > > > > Change the "pSeries" prefixes on the nvram function names to "rtas" in
> > > > > preparation for moving this code to a platform-neutral location.
> > > > >
> > > > > Signed-off-by: Nathan Lynch <ntl@pobox.com>
> > > >
> > > > Please, move them out of platform/pseries while at it, so you can also
> > > > merge with chrp nvram.c which is pretty much the same.
> > >
> > > Oh, missed that second patch of yours... good :-) Now we should see if
> > > we can fixup chrp too..
> >
> > I'll look into it, though I might be hard-pressed to find a chrp
> > machine with which to test.
>
> I haev a couple, If you don't beat me, I'll have a look at doing the
> chrp bits next week.
Actually... it turns out we can use the mmio nvram backend on maple
(at least on systems with SLOF). It seems to be quite a bit faster
than RTAS.
So I think I'll submit a patch enabling MMIO_NVRAM for maple and leave
the consolidation of the pseries and chrp nvram code as a separate
matter.
prev parent reply other threads:[~2007-01-30 20:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 0:16 [PATCH 1/2] rename pSeries nvram functions Nathan Lynch
2007-01-25 0:46 ` Benjamin Herrenschmidt
2007-01-25 0:47 ` Benjamin Herrenschmidt
2007-01-25 1:00 ` Nathan Lynch
2007-01-25 3:41 ` Benjamin Herrenschmidt
2007-01-30 20:16 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130201642.GJ9045@localdomain \
--to=ntl@pobox.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).