From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ntl@pobox.com>
Received: from rune.pobox.com (rune.pobox.com [208.210.124.79])
	by ozlabs.org (Postfix) with ESMTP id 70C1ADE05C
	for <linuxppc-dev@ozlabs.org>; Wed, 31 Jan 2007 07:16:55 +1100 (EST)
Date: Tue, 30 Jan 2007 14:16:42 -0600
From: Nathan Lynch <ntl@pobox.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/2] rename pSeries nvram functions
Message-ID: <20070130201642.GJ9045@localdomain>
References: <20070125001628.GH16486@localdomain>
	<1169686011.24996.18.camel@localhost.localdomain>
	<1169686046.24996.20.camel@localhost.localdomain>
	<20070125010010.GM16486@localdomain>
	<1169696480.24996.40.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1169696480.24996.40.camel@localhost.localdomain>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

Benjamin Herrenschmidt wrote:
> On Wed, 2007-01-24 at 19:00 -0600, Nathan Lynch wrote:
> > Benjamin Herrenschmidt wrote:
> > > On Thu, 2007-01-25 at 11:46 +1100, Benjamin Herrenschmidt wrote:
> > > > On Wed, 2007-01-24 at 18:16 -0600, Nathan Lynch wrote:
> > > > > The nvram support in the pSeries platform code is not really tied to
> > > > > the pSeries platform.  This code is useful on other platforms that
> > > > > have the necessary firmware support.
> > > > > 
> > > > > Change the "pSeries" prefixes on the nvram function names to "rtas" in
> > > > > preparation for moving this code to a platform-neutral location.
> > > > > 
> > > > > Signed-off-by: Nathan Lynch <ntl@pobox.com>
> > > > 
> > > > Please, move them out of platform/pseries while at it, so you can also
> > > > merge with chrp nvram.c which is pretty much the same.
> > > 
> > > Oh, missed that second patch of yours... good :-) Now we should see if
> > > we can fixup chrp too..
> > 
> > I'll look into it, though I might be hard-pressed to find a chrp
> > machine with which to test.
> 
> I haev a couple, If you don't beat me, I'll have a look at doing the
> chrp bits next week.

Actually... it turns out we can use the mmio nvram backend on maple
(at least on systems with SLOF).  It seems to be quite a bit faster
than RTAS.

So I think I'll submit a patch enabling MMIO_NVRAM for maple and leave
the consolidation of the pseries and chrp nvram code as a separate
matter.